Closed Bug 1820616 Opened 1 year ago Closed 1 year ago

Replace "Learn more" link on extension manage page with moz-support-link

Categories

(Toolkit :: UI Widgets, task, P3)

task

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: tgiles, Assigned: 5670375682, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [recomp] [lang=html] [lang=js])

Attachments

(1 file, 1 obsolete file)

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help.
    This will tell others that you're working on the next steps.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
    • You can also read the Developer Guide, which has answers to most development questions.
  3. Start working on this bug.
    • You will need to install an extension to your local build of Firefox
    • Navigate to about:addons, find your enabled extension and then activate the triple dot (ellipsis) menu and then navigate to "manage"
    • You will see a "Learn more" link that is a support-link instead of a moz-support-link, you will need to replace this link with moz-support-link
    • You should verify clicking the "Learn more" link navigates to a support.mozilla.org page.
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
  4. Build your change with mach build and verify your changes by ensuring clicking the link navigates you to a support.mozilla.org support page (more specially one that mentions extensions and private browsing). Also check your changes for adherence to our style guidelines by using mach lint.
  5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll push it to autoland.
Mentor: tgiles

I will like to help with this bug

Thanks for volunteering! I'll go ahead and assign you the bug, please refer to comment #0 for more information and feel free to needinfo me or reach out over on https://chat.mozilla.org/#/room/#reusable-components:mozilla.org if you need help.

Assignee: nobody → 5670375682
Status: NEW → ASSIGNED

Hi,
I'm on step 3.3
I have built and run Mozilla on my machine, I have also found the learn more link, I would like to know how should I change code?

Can I use page Inspect to change the code, Will that work? I say that on the steps above there is no reference of a GitHub repo.

Feel free to answer at anytime if I have found the solution myself I will add it below.

Flags: needinfo?(tgiles)

(In reply to ntshangase from comment #3)

Hi,
I'm on step 3.3
I have built and run Mozilla on my machine, I have also found the learn more link, I would like to know how should I change code?

Can I use page Inspect to change the code, Will that work? I say that on the steps above there is no reference of a GitHub repo.

Feel free to answer at anytime if I have found the solution myself I will add it below.

----Updaate---
I believe I have made progress, I have found the support-link which I need to change to a moz-support-link. There are 3 instance of this support-link which I think I need to change all 3 because the only difference is whether the user is on:

  1. addon-detail-private-browsing-help
  2. detail-private-disallowed-description2
  3. detail-private-required-description2

here is the link to the code I have found: https://paste.mozilla.org/t8gHnMWi

(In reply to ntshangase from comment #4)

I believe I have made progress, I have found the support-link which I need to change to a moz-support-link. There are 3 instance of this support-link which I think I need to change all 3 because the only difference is whether the user is on:

  1. addon-detail-private-browsing-help
  2. detail-private-disallowed-description2
  3. detail-private-required-description2

here is the link to the code I have found: https://paste.mozilla.org/t8gHnMWi

In the future, you can use https://searchfox.org/ to link to places in the code. For example, here's the code you posted but in searchfox. It's a very powerful indexing tool and extremely helpful 🙂

I was unaware of these other "support-links" that you posted, so it seems reasonable to replace them all. You can either replace these all at once (in one commit), or replace each link in a new commit. After changing the "support-links" over to "moz-support-links", again, please verify that the links take you to support.mozilla.org pages.

Feel free to needinfo me if you need more help!

Flags: needinfo?(tgiles)

I want to make a commit, should I select you as the reviewer?, if so what's your handle

Flags: needinfo?(tgiles)

Yes, you should select me as a reviewer. If you search for me on https://phabricator.services.mozilla.com/ you will be able to find what my handle is (or anyone else for that matter). For the most part, Mozilla staff tend to post their handle in their bugzilla name inside of square brackets. For example, [:tgiles] tells me that the person's handle should be tgiles when requesting review.

Flags: needinfo?(tgiles)
Attachment #9322219 - Attachment is obsolete: true

I see that my patch has been accepted does that mean my code is officially in the Mozilla Codebase?

Flags: needinfo?(tgiles)
Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/604222337df9
Change 3 support-links to moz-support-link. r=tgiles
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch

ntshangase, so once the status of the bug changes from "ASSIGNED" to "RESOLVED" and is "Closed" (which you can see at the top of the bug) then yes, your code has landed in Firefox!

You can see Comment #12 on this bug for what to look for in the future 🙂

Flags: needinfo?(tgiles)

(In reply to Tim Giles [:tgiles] from comment #13)

ntshangase, so once the status of the bug changes from "ASSIGNED" to "RESOLVED" and is "Closed" (which you can see at the top of the bug) then yes, your code has landed in Firefox!

You can see Comment #12 on this bug for what to look for in the future 🙂

Thanks, Those are Great news. let me start working on my second patch.

Whiteboard: [fidefe-reusable-components] [lang=html] [lang=js] → [recomp] [lang=html] [lang=js]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: