1821082 - 35.3 - 2.2% tresize / sessionrestore_no_auto_restore + 20 more (Linux, OSX, Windows) regression on Wed March 1 2023

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Andrej (:aglavic)]

Perfherder has detected a talos performance regression from push 10d16f2e1241a40683849b2e3383046925ee6398. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
35%	tresize	windows10-64-shippable-qr	e10s fission stylo webrender-sw	6.80 -> 9.20
25%	rasterflood_gradient	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	939.67 -> 704.83
20%	tresize	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	6.58 -> 7.92
19%	tresize	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	25.77 -> 30.78
15%	tart	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	3.89 -> 4.47
15%	tsvg_static	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	82.58 -> 94.97
15%	tsvgx	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	252.12 -> 289.46
10%	tp5o_scroll	windows10-64-shippable-qr	e10s fission stylo webrender	1.65 -> 1.82
10%	tsvgx	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	137.85 -> 151.58
9%	tscrollx	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	1.14 -> 1.24
...	...	...	...	...
3%	tsvgx	windows10-64-shippable-qr	e10s fission stylo webrender	163.28 -> 168.15
3%	ts_paint_webext	windows10-64-shippable-qr	e10s fission stylo webrender-sw	409.67 -> 421.17
3%	ts_paint	windows10-64-shippable-qr	e10s fission stylo webrender-sw	406.83 -> 417.33
3%	sessionrestore	windows10-64-shippable-qr	e10s fission stylo webrender-sw	447.42 -> 458.58
2%	sessionrestore_no_auto_restore	windows10-64-shippable-qr	e10s fission stylo webrender-sw	455.08 -> 465.08

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
24%	tp5o responsiveness	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	2.65 -> 2.01
16%	tp5o_webext responsiveness	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	3.26 -> 2.75
4%	displaylist_mutate	windows10-64-shippable-qr	e10s fission stylo webrender-sw	2,559.03 -> 2,463.39

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1811978

Comment 2

[Glenn Watson [:gw]]

I'll investigate this week.

Comment 3

[Glenn Watson [:gw]]

Attachment: Bug 1821082 - Fix perf regression due to too much swgl blending

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/205eb335404e
Fix perf regression due to too much swgl blending r=gfx-reviewers,lsalzman

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/205eb335404e

Comment 6

[Andrej (:aglavic)]

(In reply to Pulsebot from comment #4)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/205eb335404e
Fix perf regression due to too much swgl blending r=gfx-reviewers,lsalzman

== Change summary for alert #37649 (as of Tue, 14 Mar 2023 00:17:36 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
28%	tp5o responsiveness	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	2.09 -> 2.68
17%	tp5o_webext responsiveness	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	2.74 -> 3.19
6%	rasterflood_gradient	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	1,329.17 -> 1,253.08

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
34%	rasterflood_gradient	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	704.67 -> 943.83
31%	tresize	windows10-64-shippable-qr	e10s fission stylo webrender-sw	9.61 -> 6.67
18%	tresize	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	7.92 -> 6.49
16%	tresize	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	30.59 -> 25.75
13%	tart	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	4.50 -> 3.89
...	...	...	...	...
3%	twinopen ext+twinopen:twinopen.html	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	90.93 -> 88.59

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=37649