1821086 - Replace "connect-another-device" label with HTML anchor element

Status: RESOLVED FIXED

(Firefox :: Settings UI, task, P3)

Description

[Tim Giles [:tgiles]]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions.
3. Start working on this bug.
   • Navigate to about:preferences#sync and activate the "Sign in to sync..." button.
   • You'll need to either use your Firefox Account or create a test account for this bug, as the "Connect another device" label will not appear on the Sync page otherwise.
   • Afterwards you'll see the "Connect another device" label. You'll need to replace this label with an <html:a> element instead. Note the <html:a> is intentional in this case because we'll be working in an XHTML document instead of just a HTML document.
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
4. Build your change with mach build and verify your changes by ensuring the link takes you to a new page where it prompts you to "Connect Firefox on another device". Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 1

[Victoria Ajala]

Hello Tim Giles, I am an Outreachy applicant and I would love to work on this issue.

Comment 2

[Tim Giles [:tgiles]]

Thanks for your help! Let me know if you run into issues with this bug. Feel free to needinfo me or reach out over on Element/Matrix!

Comment 3

[Victoria Ajala]

Attachment: Bug 1821086 - Replace connect another device label with HTML anchor element r?tgiles

Comment 4

[Victoria Ajala]

Hello @tgiles. I have submitted a patch for this bug
Kindly review, Thank you.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dcf5b34283d
Replace connect another device label with HTML anchor element r=tgiles

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/1dcf5b34283d