1821387 - Site Information panel header text does not center-align vertically

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Fanolian]

Attachment: Firefox site information panel.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/112.0
Build ID: 20230309093044

Steps to reproduce

1. Click the padlock icon on address bar.

Actual result

Site Information panel header text does not center-align vertically.
Connection Security panel header text is not affected.

Regression

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=53491bc68f81d4c082d3d6cfdda617fe4deca8b0&tochange=c25af897c9bcb33045fe7664d93684de65cbf2a8
This is regressed by bug 1820534.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1821387 - Don't use vbox on panel headers. r=Gijs,dao

While at it remove useless display declaration too. The display value on
a flex item gets blockified, so we end up with block anyways which is
the default display of h1 elements.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1820534

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9638cfaa6d6
Don't use vbox on panel headers. r=Gijs

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e9638cfaa6d6

Comment 5

[Dianna Smith [:diannaS]]

This was backed out of beta v112 via bug 1820534

Comment 6

[Bogdan Maris, Desktop Test Engineering]

Reproduced using an old Nightly build before the fix, verified that using Firefox 113.0b8 across platforms (macOS 13, Windows 10, Ubuntu 22.04) the site information panel header is correctly aligned.