1827730 - Cookie banner reduction panel header text is not centered

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Itiel]

Attachment: Screenshot

Comment 1

[Itiel]

Attachment: Bug 1827730 - Don't specify the cookie banner reduction panel header in the markup and let it be created by PanelMultiView.jsm r?emilio,jhirsch

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1821387

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36513e9d1cf6
Don't specify the cookie banner reduction panel header in the markup and let it be created by PanelMultiView.jsm r=emilio

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/36513e9d1cf6

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:itiel_yn8, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox113 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Itiel]

@jhirsch, is there a point in uplifting this? Is it going to be pref'd on for 113 release?

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I think we should uplift this patch.

CBH will not be preffed on in 113, but there is a critically important search impact experiment planned for CBH. I don't know exactly when the search experiment will begin, but there's a good chance it will happen while 113 is in release. Since this is a low risk patch, probably best to just uplift it.

Comment 8

[Itiel]

Comment on attachment 9328233 [details]
Bug 1827730 - Don't specify the cookie banner reduction panel header in the markup and let it be created by PanelMultiView.jsm r?emilio,jhirsch

Beta/Release Uplift Approval Request

• User impact if declined: CBH panel header text being uncentered- see screenshot
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple markup change to make the panel use the same codepath as other panels making this more consistent with the rest of the codebase
• String changes made/needed: --
• Is Android affected?: No

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9328233 [details]
Bug 1827730 - Don't specify the cookie banner reduction panel header in the markup and let it be created by PanelMultiView.jsm r?emilio,jhirsch

Approved for 113.0b6.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/726159911ba2

Comment 11

[Ina Popescu, Desktop QA]

I've tried to verify this, but I think I'm missing some STR. Could you please provide more details how to reproduce?
Should I set cookiebanners.service.mode to 2 in about:config to have the Cookie Banner Reduction panel displayed ?

Comment 12

[Itiel]

(In reply to Ina Popescu, Desktop QA from comment #11)

I've tried to verify this, but I think I'm missing some STR. Could you please provide more details how to reproduce?
Should I set cookiebanners.service.mode to 2 in about:config to have the Cookie Banner Reduction panel displayed ?

tbh I'm not sure, this works for me when I'm in private browsing window. Forwarding the question to jhirsch.

Comment 13

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Sorry, I missed this ping. The QA work for this feature is mostly captured under bug 1816462. :ppop did the QA for the cookie banner handling feature and should be a good resource here for known / unknown edge cases.

Comment 14

[Patriciu Pop [:ppop], Ecosystem QA]

I've verified that the issue is no longer reproducible, the header is now centered in the CBH panel. Tested using Firefox Nightly 114.0a1, Build ID 20230502160708, and Firefox Beta 113.0, Build ID 20230501151611. Marking this issue as verified.