1821519 - Repair text encoding result forgotten after message preview pane is closed: Reply subsequently garbled

Status: RESOLVED WONTFIX

(Thunderbird :: Message Compose Window, defect)

Description

[PS]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/110.0.0.0 Safari/537.36

Steps to reproduce:

Follow-up to bug 1818683 comment #9:

• Display a message with incorrect charset.
• Repair text encoding now via the "More" button on the header pane.
• Close the preview.
• Reply.

Actual results:

The quote in the reply is garbled. The charset used for repair is not honoured.

Expected results:

The charset used for repair should be honoured like it was in TB 102.

Comment 1

[Thomas D. (:thomas8)]

Reporter, can you provide a testcase.eml with "incorrect charset" (remove private data from mail source)?

Comment 2

[Thomas D. (:thomas8)]

(In reply to PS from comment #0)

Follow-up to bug 1818683 comment #9:

Not sure if the this code link below might still give some ideas how to fix this.

(In reply to PS from Bug 1818683 comment #9)

(In reply to Geoff Lankow (:darktrojan) from comment #7)

The removed code doesn't work. I'm looking to see if I need to replace it or not. A lot has changed since that bug was fixed.

Thanks for the reply. The intent of this code was to cater for this case:
Display message 1, repair charset, switch off message preview, select message 2, reply. The bug was the the repaired charset from message 1 was used in the reply to message 2.

Comment 3

[PS]

Attachment: bad-encoding.eml

(In reply to Thomas D. (:thomas8) from comment #1)

Reporter, can you provide a testcase.eml with "incorrect charset" (remove private data from mail source)?

You have examples in your source tree:
mail/test/browser/message-reader/data/wronglyDeclaredUTF8.eml
mail/test/browser/message-reader/data/wronglyDeclaredShift_JIS.eml

Here's another one. In general, just change the encoding to charset=windows-1252 on any UTF-8 message produced with TB.

Comment 4

[Geoff Lankow (:darktrojan)]

When the message pane is closed, the message is forgotten. Completely. We're not going to remember things just in case the pane is opened again.