1821556 - Collect the tile position and number of rows in Glean New Tab metrics

Status: VERIFIED FIXED

(Firefox :: New Tab Page, task, P1)

Description

[Lina Butler [:lina]]

For both organic and sponsored (non-Pocket) tiles, we'd like to collect the position of the tile on the page. We also want to collect the number of tile rows, to use as the denominator.

Comment 1

[Lina Butler [:lina]]

Attachment: Bug 1821556 - Collect the tile position and number of tile rows in `newtab` pings. r?nanj!

This commit:

• Adds a position key to the topsites.{impression, click} events.
  This position is zero-based, to align with pocket_position.
• Refactors the impression stats actions in TelemetryFeed to receive
  the zero-based tile position, and adds one to the structured
  ingestion payloads and scalar values.
• Adds a new Glean metric, topsites.rows, to record the number of
  rows shown on the New Tab page.

Comment 2

[Lina Butler [:lina]]

Attachment: data-review-request.mdown

Comment 3

[Megan McCorquodale]

Comment on attachment 9325888 [details]
data-review-request.mdown

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
   Yes, this will be documented in the Glean dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?
   Yes, users can opt out of telemetry collection.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?
   Yes, this will be monitored by the New Tab working group.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
   Category 2, interaction data.

5. Is the data collection request for default-on or default-off?
   Default on.

6. Does the instrumentation include the addition of any new identifiers?
   No new identifiers.

7. Is the data collection covered by the existing Firefox privacy notice?
   Yes.

8. Does the data collection use a third-party collection tool?
   No.

---

data-review +

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4a013c5b1fa
Collect the tile position and number of tile rows in `newtab` pings. r=nanj

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e4a013c5b1fa

Comment 6

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 114.0a1 build (Build ID: 20230507095340) and the latest Beta 113.0b9 (Build ID: 20230504192738) on Windows 10 x64, macOS 13.1 and Linux Mint 20.

• The number of rows is correctly registered in Glean, eg:
  "quantity": {
  "topsites.rows": 2
  }

• The tile position is correctly registered in Glean, eg:

  {
  "timestamp": 41,
  "category": "topsites",
  "name": "impression",
  "extra": {
  "position": "1",
  "is_sponsored": "false",
  "newtab_visit_id": "{3d125c24-165e-4ab1-ba03-004c33a87277}"
  }