[gtk2] random crashing on toplevel focus in/out

RESOLVED FIXED

Status

Core Graveyard
Embedding: GTK Widget
--
critical
RESOLVED FIXED
16 years ago
6 years ago

People

(Reporter: Tommi Komulainen, Assigned: blizzard)

Tracking

({crash})

Trunk
x86
Linux
crash

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

16 years ago
User-Agent:       Mozilla/5.0 Galeon/1.3 (Turing 42;) Gecko
Build Identifier: 

Quite randomly the gtkmozembed widget crashes in toplevel focus in/out events.

Reproducible: Sometimes

Steps to Reproduce:
1.Create new gtkmozembed
2.Generate toplevel focus in/out events
3.Repeat from 1) until crashes

Actual Results:  
Boom!

Expected Results:  
No boom.
(Reporter)

Comment 1

16 years ago
Created attachment 107575 [details] [diff] [review]
Use same types for signal_connect and in the signal handler

The type of the parameter that is used when connecting the
toplevel_focus_in/out signals is different from the type that the handler tries
to use.  That is obviously bad.

Updated

16 years ago
Keywords: crash
(Assignee)

Comment 2

16 years ago
Comment on attachment 107575 [details] [diff] [review]
Use same types for signal_connect and in the signal handler

we can just fix what's passed in
Attachment #107575 - Flags: review-
(Assignee)

Updated

16 years ago
Blocks: 92033
(Assignee)

Comment 3

16 years ago
Created attachment 107620 [details] [diff] [review]
patch

Change the type passed in instead of fixing the functions.
Attachment #107575 - Attachment is obsolete: true
Comment on attachment 107620 [details] [diff] [review]
patch

Yeah, so how _did_ that ever work?
Attachment #107620 - Flags: superreview+
(Assignee)

Comment 5

16 years ago
I swear I remember testing it.

Comment 6

16 years ago
Comment on attachment 107620 [details] [diff] [review]
patch

r=tor
Attachment #107620 - Flags: review+
(Assignee)

Comment 7

16 years ago
Fixed.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Component: Embedding: GTK Widget → Embedding: GTK Widget
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.