182162 - [gtk2] random crashing on toplevel focus in/out

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Tommi Komulainen]

User-Agent:       Mozilla/5.0 Galeon/1.3 (Turing 42;) Gecko
Build Identifier: 

Quite randomly the gtkmozembed widget crashes in toplevel focus in/out events.

Reproducible: Sometimes

Steps to Reproduce:
1.Create new gtkmozembed
2.Generate toplevel focus in/out events
3.Repeat from 1) until crashes

Actual Results:  
Boom!

Expected Results:  
No boom.

Comment 1

[Tommi Komulainen]

Attachment: Use same types for signal_connect and in the signal handler

The type of the parameter that is used when connecting the
toplevel_focus_in/out signals is different from the type that the handler tries
to use.  That is obviously bad.

Comment 2

[Christopher Blizzard (:blizzard)]

Comment on attachment 107575 [details] [diff] [review]
Use same types for signal_connect and in the signal handler

we can just fix what's passed in

Comment 3

[Christopher Blizzard (:blizzard)]

Attachment: patch

Change the type passed in instead of fixing the functions.

Comment 4

[Mike Shaver (:shaver emeritus)]

Comment on attachment 107620 [details] [diff] [review]
patch

Yeah, so how _did_ that ever work?

Comment 5

[Christopher Blizzard (:blizzard)]

I swear I remember testing it.

Comment 6

[tor]

Comment on attachment 107620 [details] [diff] [review]
patch

r=tor

Comment 7

[Christopher Blizzard (:blizzard)]

Fixed.