1821661 - FAIL Uncaught exception received from previously timed out test bound testEncryptedMessageReplyIsEncrypted - focus listener not removed before the end of test

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert [:KaiE:]]

I see this test failure locally:
FAIL Uncaught exception received from previously timed out test bound testEncryptedMessageReplyIsEncrypted - focus listener not removed before the end of test

I have a fix.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Bug 1821661 - Fix test testEncryptedMessageReplyIsEncrypted. r=#thunderbird-reviewers

Comment 2

[Kai Engert [:KaiE:]]

Maybe this failure is related to bug 1808258, but it produces a different error.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2527a3441972
Fix test testEncryptedMessageReplyIsEncrypted. r=leftmostcat

Comment 4

[Kai Engert [:KaiE:]]

It's still failing on treeherder.
(bct7, linux x64 opt)

That's confusing, because it works for me locally. Most of the time.

Exactly ONCE I was able to see a failure locally. It was apparently stuck while trying to click the save button. I saw that the save button wasn't simply clicked, but the button's dropdown menu was open (which offers several ways for saving).

I looked at the code that triggers saving, but I don't understand how this could have happened. And I don't know if that one-time local event is actually the thing that goes wrong on treeherder.

Instead I attempted to change other places in this code to reuse existing test helpers.

I also found two more things that might help. The initial be_in_folder didn't make sense for this test. We should be in the draft folders. With some added sleep calls, I attempted to look at window behavior. I had the impression that saving didn't work right (but I don't understand why the test still worked for me locally). By changing the initial call to be_in_folder(gDrafts), I saw that saving to the drafts folder worked. (Or at least I could see it, because the 3pane window was switched to that folder.) But that alone wasn't sufficient to fix the bug.
(failed try: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=15ad747c87cead292445262ad12529cd80c59e4a)

Despite my lack of understanding, my additional experiments I found code that actually works in treeherder.
Working try:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=4165d9f9deab6a48112906d878590c1e7d3fe617

Comment 5

[Kai Engert [:KaiE:]]

Attachment: Bug 1821661 - Another attempt to fix testEncryptedMessageReplyIsEncrypted (works in try). r=mkmelin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5cb4e6ab51e0
Another attempt to fix testEncryptedMessageReplyIsEncrypted (works in try). r=mkmelin