Closed Bug 1821704 Opened 1 year ago Closed 1 year ago

Fix ordering of toolkit/content/test/browser/browser.ini

Categories

(Toolkit :: General, task, P3)

task

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: tgiles, Assigned: annhermy, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=ini])

Attachments

(1 file)

I noticed when working on Bug 1813077 that I got a lint warning in toolkit/content/test/browser/browser.ini due to a new test I added. We should fix this warning and alphabetize this test manifest.

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help.
    This will tell others that you're working on the next steps.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
    • You can also read the Developer Guide, which has answers to most development questions.
  3. Start working on this bug.
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
  4. Build your change with mach build and test your change with mach test toolkit/content/test/browser/browser.ini --headless. Also check your changes for adherence to our style guidelines by using mach lint.
    • You should verify the amount of failures (if any) before and after your changes to ensure there were no additional issues with alphabetizing the manifest.
  5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll push it to autoland.
Mentor: tgiles
Keywords: good-first-bug
Whiteboard: [lang=ini]

Hi, I am an Outreachy applicant and would like to work on this issue

I've gone ahead and assigned you to the bug, please feel free to needinfo me if you need help!

Assignee: nobody → annhermy
Status: NEW → ASSIGNED

I really appreciate that, thank you!

I have a question. I've run the test (./mach test toolkit/content/test/browser/browser.ini --headless) before and after my changes and result was the same with several failed tests. Here is the output:
https://paste.mozilla.org/VEzqCsci

Flags: needinfo?(tgiles)

(In reply to Ganna from comment #5)

I have a question. I've run the test (./mach test toolkit/content/test/browser/browser.ini --headless) before and after my changes and result was the same with several failed tests. Here is the output:
https://paste.mozilla.org/VEzqCsci

If the same tests in the same spots failed before and after your changes, then I believe we're good to go. You can go ahead and submit a patch and I can review it.

Flags: needinfo?(tgiles)
Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bae531b76c39
Fix ordering of toolkit/content/tests/browser/browser.ini r=tgiles
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: