Fix ordering of toolkit/content/test/browser/browser.ini
Categories
(Toolkit :: General, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: tgiles, Assigned: annhermy, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [lang=ini])
Attachments
(1 file)
I noticed when working on Bug 1813077 that I got a lint warning in toolkit/content/test/browser/browser.ini due to a new test I added. We should fix this warning and alphabetize this test manifest.
|
Reporter | |
Comment 1•7 months ago
|
||
To help Mozilla out with this bug, here's the steps:
- Comment here on the bug that you want to volunteer to help.
This will tell others that you're working on the next steps. - Download and build the Firefox source code
- If you have any problems, please ask on Element/Matrix in the
#introductionchannel. They're there to help you get started. - You can also read the Developer Guide, which has answers to most development questions.
- If you have any problems, please ask on Element/Matrix in the
- Start working on this bug.
- You will need to alphabetize the
toolkit/content/test/browser/browser.inifile. - For example, the
browser_about_logging.jsentry needs to be the first test manifest entry in the list. This means moving lines 157 through 147 up to line 25. - Make sure you keep an empty line after line 23 in the manifest
- If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the
#reusable-componentschannel on Element/Matrix most hours of most days.
- You will need to alphabetize the
- Build your change with
mach buildand test your change withmach test toolkit/content/test/browser/browser.ini --headless. Also check your changes for adherence to our style guidelines by usingmach lint.- You should verify the amount of failures (if any) before and after your changes to ensure there were no additional issues with alphabetizing the manifest.
- Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
- How to Submit a Patch
- This is when the bug will be assigned to you.
- After a series of reviews and changes to your patch, I'll push it to autoland.
- If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
- Your code will soon be shipping to Firefox users worldwide!
Hi, I am an Outreachy applicant and would like to work on this issue
|
|
Reporter | |
Comment 3•7 months ago
|
||
I've gone ahead and assigned you to the bug, please feel free to needinfo me if you need help!
I have a question. I've run the test (./mach test toolkit/content/test/browser/browser.ini --headless) before and after my changes and result was the same with several failed tests. Here is the output:
https://paste.mozilla.org/VEzqCsci
|
|
Reporter | |
Comment 6•7 months ago
|
||
(In reply to Ganna from comment #5)
I have a question. I've run the test (./mach test toolkit/content/test/browser/browser.ini --headless) before and after my changes and result was the same with several failed tests. Here is the output:
https://paste.mozilla.org/VEzqCsci
If the same tests in the same spots failed before and after your changes, then I believe we're good to go. You can go ahead and submit a patch and I can review it.
Pushed by tgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bae531b76c39 Fix ordering of toolkit/content/tests/browser/browser.ini r=tgiles
|
||
Comment 9•6 months ago
|
||
| bugherder | ||
Description
•