Closed Bug 1813077 Opened 1 year ago Closed 1 year ago

Replace "addon-install-blocked-info" link with moz-support-link

Categories

(Toolkit :: UI Widgets, task, P3)

task

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: tgiles, Assigned: tgiles)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [recomp])

Attachments

(4 files, 1 obsolete file)

In popup-notifications.inc there is a learn more link that is a SUMO link. We can see this in browser-addons.js, but there is a bit of a tricky situation in this case. This is because the SUMO article chosen is generated dynamically and the text associated with this link comes from a .properties files and not Fluent.

Also, should this bug be under XUL Widgets or Add-ons Manager?

Whiteboard: [fidefe-reusable-components-ms1] → [fidefe-reusable-components-ms2]
Assignee: nobody → tgiles
Status: NEW → ASSIGNED
Summary: Replace "addon-installed-blocked-info" link with moz-support-link → Replace "addon-install-blocked-info" link with moz-support-link
Duplicate of this bug: 1814260

The moz-support-link was initially designed for in-content use.
Since there are places where this component can be used in chrome, we
need to add the ability for this widget to open links when used in the
chrome.

Since we can't synchronously load ESModules yet, we use a new
abstraction of ensureCustomElements to ensure we have access to the
moz-support-link widget in popup-notifications.inc. The previous pattern
of loading the widget via module script does not work in this case due
to browser.xhtml, as we do not want to block on this path.

Depends on D170253

The previous way of setting textContent via string from the
browser.properties file does not work with the moz-support-link widget
since it has a Fluent ID by default. Instead we migrate the existing
string from the browser.properties file to the respective ftl file.

Depends on D170254

Attachment #9319764 - Attachment is obsolete: true
Blocks: 1814266
Blocks: 1814261
Blocks: 1814270
Blocks: 1814409
Blocks: 1814411
Blocks: 1814412
Blocks: 1814431
Blocks: 1819360
Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87bea273fd3a
Add ability for moz-support-link to open links in chrome. r=mstriemer
https://hg.mozilla.org/integration/autoland/rev/eac5effa932d
Add import of moz-support-link for use in popup-notification via ensureCustomElements. r=mstriemer,extension-reviewers
https://hg.mozilla.org/integration/autoland/rev/beb14240b4e6
Make addon-install-blocked learn more link use Fluent. r=mstriemer,fluent-reviewers,extension-reviewers,Gijs,flod
https://hg.mozilla.org/integration/autoland/rev/30c52283ff96
Style anchor elements in the chrome like XUL text links. r=dao
Regressions: 1824178
Regressions: 1826824
Whiteboard: [fidefe-reusable-components-ms2] → [recomp]
You need to log in before you can comment on or make changes to this bug.