Replace "addon-install-blocked-info" link with moz-support-link
Categories
(Toolkit :: UI Widgets, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: tgiles, Assigned: tgiles)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [recomp])
Attachments
(4 files, 1 obsolete file)
In popup-notifications.inc there is a learn more link that is a SUMO link. We can see this in browser-addons.js, but there is a bit of a tricky situation in this case. This is because the SUMO article chosen is generated dynamically and the text associated with this link comes from a .properties
files and not Fluent.
Also, should this bug be under XUL Widgets or Add-ons Manager?
Updated•1 year ago
|
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 2•1 year ago
|
||
The moz-support-link was initially designed for in-content use.
Since there are places where this component can be used in chrome, we
need to add the ability for this widget to open links when used in the
chrome.
Assignee | ||
Comment 3•1 year ago
|
||
Since we can't synchronously load ESModules yet, we use a new
abstraction of ensureCustomElements to ensure we have access to the
moz-support-link widget in popup-notifications.inc. The previous pattern
of loading the widget via module script does not work in this case due
to browser.xhtml, as we do not want to block on this path.
Depends on D170253
Assignee | ||
Comment 4•1 year ago
|
||
The previous way of setting textContent via string from the
browser.properties file does not work with the moz-support-link widget
since it has a Fluent ID by default. Instead we migrate the existing
string from the browser.properties file to the respective ftl file.
Depends on D170254
Assignee | ||
Comment 5•1 year ago
|
||
Updated•1 year ago
|
Assignee | ||
Comment 6•1 year ago
|
||
Depends on D170255
Pushed by tgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/87bea273fd3a Add ability for moz-support-link to open links in chrome. r=mstriemer https://hg.mozilla.org/integration/autoland/rev/eac5effa932d Add import of moz-support-link for use in popup-notification via ensureCustomElements. r=mstriemer,extension-reviewers https://hg.mozilla.org/integration/autoland/rev/beb14240b4e6 Make addon-install-blocked learn more link use Fluent. r=mstriemer,fluent-reviewers,extension-reviewers,Gijs,flod https://hg.mozilla.org/integration/autoland/rev/30c52283ff96 Style anchor elements in the chrome like XUL text links. r=dao
Comment 8•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/87bea273fd3a
https://hg.mozilla.org/mozilla-central/rev/eac5effa932d
https://hg.mozilla.org/mozilla-central/rev/beb14240b4e6
https://hg.mozilla.org/mozilla-central/rev/30c52283ff96
Updated•28 days ago
|
Description
•