1821803 - [wmfme] fix issues for connecting CDM to the media engine

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P2)

Description

[Alastor Wu [:alwu]]

MFMediaEngineStream::IsEncrypted() didn't return the correct result, because we didn't serialize the crypto information. This bug will fix some issues related with that.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1821803 - part1 : serialize crypto info over IPC.

This patch makes MFMediaEngineStream::IsEncrypted() return correct
result by checking the serialized crypto information.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1821803 - part2 : for encrypted content, set the media source after ensuring the cdm proxy.

Once we set the media source to the media engine, if it's an encrypted
content, MFMediaSource::GetInputTrustAuthority will be called by the
media engine.

There is no return code [1] indicating the CDM proxy would be set later,
so we can't set the source too early. Otherwise, media engine would
treat an encrypted content as a clear content, which results in errors.

[1]
https://learn.microsoft.com/en-us/windows/win32/api/mfidl/nf-mfidl-imftrustedinput-getinputtrustauthority

Depends on D172486

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1821803 - part3 : set size on the streamBlob.

The ctor for the nsTArray only sets the capacity, not size, so we need
to set it explicitly.

Depends on D172487

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1821803 - part4 : prevent setting CDM before the engine initialization.

Depends on D172488

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14892860eaee
part1 : serialize crypto info over IPC. r=jolin
https://hg.mozilla.org/integration/autoland/rev/a2ddd3db75c2
part2 : for encrypted content, set the media source after ensuring the cdm proxy. r=jolin
https://hg.mozilla.org/integration/autoland/rev/ec91bc6abbd4
part3 : set size on the streamBlob. r=jolin
https://hg.mozilla.org/integration/autoland/rev/75db8a0db46f
part4 : prevent setting CDM before the engine initialization. r=jolin

Comment 6

[Marian-Vasile Laza]

Backed out 4 changesets (Bug 1821803) for build bustages on MFMediaEngineParent.cpp.
Backout link
Push with failures <--> B
Failure Log

Comment 7

[Alastor Wu [:alwu]]

Try result looks good.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33243f7459b8
part1 : serialize crypto info over IPC. r=jolin
https://hg.mozilla.org/integration/autoland/rev/e30242a2764c
part2 : for encrypted content, set the media source after ensuring the cdm proxy. r=jolin
https://hg.mozilla.org/integration/autoland/rev/05ff31b997f9
part3 : set size on the streamBlob. r=jolin
https://hg.mozilla.org/integration/autoland/rev/51fc535f06ec
part4 : prevent setting CDM before the engine initialization. r=jolin

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/33243f7459b8
https://hg.mozilla.org/mozilla-central/rev/e30242a2764c
https://hg.mozilla.org/mozilla-central/rev/05ff31b997f9
https://hg.mozilla.org/mozilla-central/rev/51fc535f06ec