1821808 - Spaces pinned button is only visually collapsed but it still occupies space

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Alessandro Castellani [:aleca]]

When the spaces toolbar is visible, the spaces "pinned" toolbar button is collapsed="true".
This makes it visually hidden, but in reality it still occupies some space in the DOM, interfering with the available drag space.
This is most noticeable when no buttons are present in the unified toolbar and the drag action is initiated at the start of the toolbar.
We should convert this button to be actually hidden and not collapsed.

Probably this issue started with the flexbox emulation, but I'm putting this as a blocker of the unified toolbar because it interferes with it's expected usability.

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: Bug 1821808 - Make the spaces pinned button hidden instead of collapsed. r=#thunderbird-front-end-reviewers

Comment 2

[Alessandro Castellani [:aleca]]

Try run: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=25d65c758c4f123010f187ad85eca9e29e420b40

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c7717aec2f9e
Make the spaces pinned button hidden instead of collapsed. r=Paenglab

Comment 4

[Alessandro Castellani [:aleca]]

Reopening due to test failures.
That's why I didn't mark this for check-in since I wasn't sure if the failures I saw in the try run were caused by these changes

Comment 5

[Alessandro Castellani [:aleca]]

Attachment: Bug 1821808 - Fix spaces toolbar tests. r=darktrojan

Comment 6

[Alessandro Castellani [:aleca]]

try run: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=685cf2e6d081469cad8491136ea590b597a7b43f

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6e87f077e6a8
Fix spaces toolbar tests. r=darktrojan

Comment 8

[Alessandro Castellani [:aleca]]

Comment on attachment 9322865 [details]
Bug 1821808 - Fix spaces toolbar tests. r=darktrojan

[Approval Request Comment]
Regression caused by: this bug
User impact if declined: no user impact, only failing tests
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9322865 [details]
Bug 1821808 - Fix spaces toolbar tests. r=darktrojan

[Triage Comment]
Approved for beta

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 112.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/dc829d53e78c