1821956 - [CTW] Remove Windows code which uses COM proxies when the cache is disabled

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

When we're ready to drop the non-caching implementation, once the cache is pushed regardless of the pref, we need to stop Windows from ever using COM proxies for RemoteAccessible. This will involve removing code which only runs when the cache is disabled and enabling code which doesn't run when the cache is enabled in MsaaAccessible, DocAccessibleParent specific to Windows, win RemoteAccessible, BrowserParent, DocAccessible specific to Windows, DocAccessibleChildBase specific to Windows, win DocAccessibleChild and xpAccessible* specific to Windows. And probably other stuff too. :)

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1821956 part 1: Remove content process COM proxy support from MsaaAccessible, ia2Accessible, etc.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1821956 part 2: Remove content process MSAA id generation.

Because a11y clients only talk to the parent process now, content processes don't need to generate MSAA ids.
They're all generated in the parent process.

Comment 3

[James Teh [:Jamie]]

Attachment: Bug 1821956 part 3: Remove AccessibleHandlerControl code from AccessibleWrap.

AccessibleHandler and AccessibleHandlerControl are only used for content process COM proxies.

Comment 4

[James Teh [:Jamie]]

Attachment: Bug 1821956 part 4: Remove COM proxy, HWND and MSAA id code from PDocAccessible.

All of this is only used to support content process COM proxies.

Comment 5

[James Teh [:Jamie]]

Attachment: Bug 1821956 part 5: Remove COM proxy support from PBrowserBridge.

Comment 6

[James Teh [:Jamie]]

Attachment: Bug 1821956 part 6: Remove event deferral and sync text change events from Windows PDocAccessible.

We only needed to defer events because of the need to wait for a parent COM proxy.
Similarly, sync text change events (as opposed to async) were only necessary with the COM proxy architecture.
Now that there are no COM proxies, neither of these are necessary.

Comment 7

[James Teh [:Jamie]]

Attachment: Bug 1821956 part 7: Remove DocAccessibleChildBase::IsConstructedInParentProcess.

Now that we don't defer events on Windows, this isn't necessary on Windows.
Usage of this on other platforms was removed in bug 1821957.

Comment 8

[James Teh [:Jamie]]

Attachment: Bug 1821956 part 8: Remove most of the remaining parts of Windows RemoteAccessible.

This only worked with the COM proxy architecture.
It cannot be used with the cache active.
This includes ScrollSubstringToPoint, and since that isn't currently supported by the cache, it isn't supported at all on Windows now.
However, no one seems to use this on Windows and this implementation can't be used with the cache active anyway.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/088ad25ecb0c
part 1: Remove content process COM proxy support from MsaaAccessible, ia2Accessible, etc. r=nlapre
https://hg.mozilla.org/integration/autoland/rev/4f41b57e3774
part 2: Remove content process MSAA id generation. r=nlapre,ipc-reviewers,taskgraph-reviewers,mccr8,jmaher
https://hg.mozilla.org/integration/autoland/rev/087520ee184d
part 3: Remove AccessibleHandlerControl code from AccessibleWrap. r=nlapre
https://hg.mozilla.org/integration/autoland/rev/660d80a23444
part 4: Remove COM proxy, HWND and MSAA id code from PDocAccessible. r=nlapre
https://hg.mozilla.org/integration/autoland/rev/695a4eb01489
part 5: Remove COM proxy support from PBrowserBridge. r=nlapre
https://hg.mozilla.org/integration/autoland/rev/8e785cfa8f76
part 6: Remove event deferral  and sync text change events from Windows PDocAccessible. r=nlapre
https://hg.mozilla.org/integration/autoland/rev/9bb2dea6c27b
part 7: Remove DocAccessibleChildBase::IsConstructedInParentProcess. r=nlapre
https://hg.mozilla.org/integration/autoland/rev/5ee3f5eab346
part 8: Remove most of the remaining parts of Windows RemoteAccessible. r=nlapre
https://hg.mozilla.org/integration/autoland/rev/87b8a158cf21
apply code formatting via Lando

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/088ad25ecb0c
https://hg.mozilla.org/mozilla-central/rev/4f41b57e3774
https://hg.mozilla.org/mozilla-central/rev/087520ee184d
https://hg.mozilla.org/mozilla-central/rev/660d80a23444
https://hg.mozilla.org/mozilla-central/rev/695a4eb01489
https://hg.mozilla.org/mozilla-central/rev/8e785cfa8f76
https://hg.mozilla.org/mozilla-central/rev/9bb2dea6c27b
https://hg.mozilla.org/mozilla-central/rev/5ee3f5eab346
https://hg.mozilla.org/mozilla-central/rev/87b8a158cf21