1821963 - [CTW] Remove COM proxy infrastructure

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

Once we no longer depend on COM proxies, we can remove all the supporting infrastructure, including HandlerProvider, AccessibleHandler, most of a11y::PlatformInit, GeckoCustom, the installer + MSIX + build system stuff associated with the handler and typelibs, code within ACCESSIBILITY defines in ipc/mscom, WaitForSyncNotifyWithA11yReentry in ipc/glue, and probably more I've missed.

Comment 1

[Marco Zehe (:MarcoZ)]

Don't know if it is relevant, but the Thunderbird team should be made aware of this so they know when the handler is to be removed. I don't suspect there will be many issues, especially since TB works better with CTW enabled anyway, even in the ESR version they're using, but they should be made aware anyway that something will de-register the handler with a Firefox update at some point.

Comment 2

[James Teh [:Jamie]]

Thunderbird has used different UUIDs for the handler for a while now, so this shouldn't break them.

Comment 3

[James Teh [:Jamie]]

Attachment: Bug 1821963 part 1: Remove NSIS and MSIX pieces supporting the old accessibility architecture based on content process COM proxies.

Comment 4

[James Teh [:Jamie]]

Attachment: Bug 1821963 part 2: Remove COM registration supporting the old accessibility architecture based on content process COM proxies.

Comment 5

[James Teh [:Jamie]]

Attachment: Bug 1821963 part 3: Remove various components supporting the old accessibility architecture based on content process COM proxies.

This includes AccessibleHandler, HandlerProvider and the now unnecessary IAcessible2 COM proxy dll.
Even with the new architecture, we still use IAccessible2, but we no longer need a COM proxy because we aren't using COM across processes ourselves.
If clients want to use IAccessible2 across processes, they're responsible for registering a COM proxy as with all other IAccessible2 applications.

Comment 6

[James Teh [:Jamie]]

Attachment: Bug 1821963 part 4: Remove alertable wait from IPC message loops.

This was only ever used by the old accessibility architecture based on content process COM proxies, which is now being removed.

Comment 7

[James Teh [:Jamie]]

Attachment: Bug 1821963 part 5: Remove code to prevent handling of window messages while handling PDocAccessible sync IPDL calls.

This actually hasn't ever been used in a shipping build of Firefox.
Although sync IPDL was tried with Windos a11y for a while when e10s was still disabled, it was never feasible and was replaced with COM proxying.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6de2b9548dc6
part 1: Remove NSIS and MSIX pieces supporting the old accessibility architecture based on content process COM proxies. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/706e46fc2688
part 2: Remove COM registration supporting the old accessibility architecture based on content process COM proxies. r=nlapre,bobowen
https://hg.mozilla.org/integration/autoland/rev/f2fba0ef15d9
part 3: Remove various components supporting the old accessibility architecture based on content process COM proxies. r=nlapre,nalexander
https://hg.mozilla.org/integration/autoland/rev/4ed7ca0eb04a
part 4: Remove alertable wait from IPC message loops. r=handyman
https://hg.mozilla.org/integration/autoland/rev/da6cba0b0dd4
part 5: Remove code to prevent handling of window messages while handling PDocAccessible sync IPDL calls. r=handyman
https://hg.mozilla.org/integration/autoland/rev/a92c62e304f0
apply code formatting via Lando

Comment 9

[Narcis Beleuzu [:NarcisB]]

Backed out for build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/f4dd1d973e6af5ff602aedbf4349fef32fe2db3f
Log link: https://treeherder.mozilla.org/logviewer?job_id=416570108&repo=autoland&lineNumber=69478

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c426299b75bc
part 1: Remove NSIS and MSIX pieces supporting the old accessibility architecture based on content process COM proxies. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/6e7c8f403f9b
part 2: Remove COM registration supporting the old accessibility architecture based on content process COM proxies. r=nlapre,bobowen
https://hg.mozilla.org/integration/autoland/rev/9bbf88ecda1d
part 3: Remove various components supporting the old accessibility architecture based on content process COM proxies. r=nlapre,nalexander
https://hg.mozilla.org/integration/autoland/rev/52fc00be37e9
part 4: Remove alertable wait from IPC message loops. r=handyman
https://hg.mozilla.org/integration/autoland/rev/007da88a0da1
part 5: Remove code to prevent handling of window messages while handling PDocAccessible sync IPDL calls. r=handyman
https://hg.mozilla.org/integration/autoland/rev/97bab904eba3
1821972: apply code formatting via Lando

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c426299b75bc
https://hg.mozilla.org/mozilla-central/rev/6e7c8f403f9b
https://hg.mozilla.org/mozilla-central/rev/9bbf88ecda1d
https://hg.mozilla.org/mozilla-central/rev/52fc00be37e9
https://hg.mozilla.org/mozilla-central/rev/007da88a0da1
https://hg.mozilla.org/mozilla-central/rev/97bab904eba3