Closed Bug 1822312 Opened 1 year ago Closed 1 year ago

Send brand images from each browser migrator class down to the Migration Wizard, and set the images in the panel-list / selector button

Categories

(Firefox :: Migration, task, P1)

task

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: mconley, Assigned: portiawuu)

References

Details

Attachments

(1 file)

In bug 1809352, we added a new static member to MigratorBase - each MigratorBase subclass now provides a brandImage URL that points to a packaged image for that particular browser.

We're going to want to show those images in the new Migration Wizard in the new selector / dropdown. This is part of the plumbing to enable that work - the end result won't be user visible, but it'll make adding the images to the selector / dropdown easier.

This should merely be the work of adding a brandImage property to the object that's being serialized / sent down to the Migration Wizard here: https://searchfox.org/mozilla-central/rev/dbec4165e4c26a0ff970b614842b689e8357593c/browser/components/migration/MigrationWizardParent.sys.mjs#258

Something like:

    return {
      key: migrator.constructor.key,
      displayName,
      brandImage: migrator.constructor.brandImage,
      resourceTypes: availableResourceTypes,
      profile: profileObj,
    };

should work.

Assignee: nobody → rmacoy
Severity: -- → N/A
Priority: -- → P1
Assignee: rmacoy → portiawuu

I'm expanding this bug to also include setting the brand images in the panel-list and putting the selected item's brand image in the selector button after selection.

Summary: Send brand images from each browser migrator class down to the Migration Wizard → Send brand images from each browser migrator class down to the Migration Wizard, and set the images in the panel-list / selector button
Attachment #9324893 - Attachment description: Bug 1822312 Send brand images from each browser migrator class down to the Migration Wizard, and set the images in the panel-list / selector button. r=mconley,kpatenio,niklas → Bug 1822312 - Send brand images from each browser migrator class down to the Migration Wizard, and set the images in the panel-list / selector button. r=mconley!
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63679b370ba5
Send brand images from each browser migrator class down to the Migration Wizard, and set the images in the panel-list / selector button. r=mconley
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: