1822576 - Search bar dropdown list glitches when very fast typing / delete

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Alice0775 White]

Attachment: screenshot

Search bar dropdown list glitches

Steps to reproduce:

1. Enable Search Bar
2. Very fast typing hjhjhjhj or any word
3. Press and hold Back Space key
4. Repeat from step2.

Actual results:
Eventually, the dropdown does not render correctly.
The dropdown height is not properly adjusted, so the results list appears to be overlapping.

Expected Results:
The dropdown should be changed to an appropriate height depending on the number of listings.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=40a93120bacc5957b5da058bfcab903a2a184adf&tochange=aa9a63adab87ae4bdd4841965e6c26db12584f0c

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1822131, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Fanolian]

Alternative STR:

1. Enable search bar.
2. Mouse click the search bar to focus it.
3. Without typing anything, press down arrow once to call out the search engines dropdown list.
4. Type a letter.

This reproduces the bug more reliably for me.

Comment 3

[Fanolian]

Or, even simpler, click the magnifying glass icon to pop out the list and start typing.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1822576 - Don't allow shrinking autocomplete-richlistitems. r=Gijs,dao,itiel

Since we rely on the richlistbox having a fixed height with multiple
items, then measure (so shrinking breaks that measurement).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4212646e1303
Don't allow shrinking autocomplete-richlistitems. r=Gijs

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4212646e1303

Comment 8

[Caspy7]

Immediately after this was fixed I began experiencing multiple issues related to the search bar on Nightly - including when typing fast. I filed bug 1823144