1823144 - Default-sized searchbar grows in size when typing.

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Caspy7]

Attachment: image.png

The other day on Nightly I experienced bug 1822576 in which typing fast caused the search suggestions to appear mangled. The next build after that was fixed the search box itself is suddenly much wider than it should be (leaving little room for the URL bar), typing text in the Search bar resizes it further (adding the ➡ on the right moves the box to the left). And I don't know if this started on the next build or soon after but now typing quickly in the search box, the search suggestions are left aligned on my display rather than aligned to the search box.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

I can't repro this (on Linux at least). My guess is that they're unrelated (probably the later related to bug 1809084), but hard to say without reproing. If you can repro this consistently can you run mozregression please?

If not: What OS are you on? Windows?

Comment 2

[Alice0775 White]

I can reproduce the width problem on Nightly113.0a1 Ubuntu20.04, Windows10 and Windows11

STR

1. Add Search bar in toolbar from about:preferences#search.
   (Do not change the width of the search bar manually. i.e, leave the width automatically determined.)
2. Type something

Actual results:
Width of serchbar changes
Screencast: https://youtu.be/iNmPHcld7EU

Comment 3

[Alice0775 White]

Regression window of the size change problem:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2cc925315ab4bc13d89167646695eece8d6f6a63&tochange=b50655fcce3faf31b2c1779c263ac7c1bca94863

Comment 4

[Caspy7]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

I can't repro this (on Linux at least). My guess is that they're unrelated (probably the later related to bug 1809084), but hard to say without reproing. If you can repro this consistently can you run mozregression please?

If not: What OS are you on? Windows?

I've had some bad experience in the past with mozregression so I may or may not be able to get back with you on that.

I'm on Windows 11.

Yes, I can consistently reproduce all of this. Looks like there's a second step I didn't realize for the dropdown alignment issue:

1. Open new window
2. Hit ctrl+K to focus search bar (search bar must be enabled of course)
3. type "test"
4. delete "test"
5. type "test" again quickly

Comment 5

[Alice0775 White]

I can also reproduce the panel position misplace issue (the dropdown shifted to the left) on Windows10, Windows11 and Ubuntu20.04 as well.

The reproducibility is about 1/10-/120, but you may need many search engines to reproduce it.

Regression Window of the misplaced problem:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=526b311af03354ed0f06ec7572b486a51bc884f6&tochange=c15f0fb1c92375ea751b3916a4c25a34403f21b2

Comment 6

[Alice0775 White]

Attachment: ubuntu20.04, the panel is misplaced.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1823144 - Don't use flex-basis: auto for searchbar without explicit width. r=Gijs,dao

This fixes comment 2. Without a explicit width our basis depends on our
contents which ends up meaning max-content now.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Let's split this into two bugs for proper tracking.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02b47d7b0b13
Don't use flex-basis: auto for searchbar without explicit width. r=Gijs

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/02b47d7b0b13