1822688 - Implement repackaging Thunderbird ESR and Beta as a Flatpak

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Daniel Darnell [:dandarnell]]

To distribute Thunderbird as a Flatpak:

• Thunderbird must be repackaged as a Flatpak
• The Thunderbird Flatpak must be pushed to Flathub

This bug is for everything related to repackaging Thunderbird as a Flatpak.

Comment 1

[Daniel Darnell [:dandarnell]]

Attachment: Bug 1822688 - Implement Flatpak repackage. r=#thunderbird-build-system-reviewers

Comment 2

[Emerson Bernier]

Since phabricator doesn't allow me to submit review (what a pity) I add a poor man attempt here:

Please change
export TMPDIR=$XDG_CACHE_HOME/tmp
to
export TMPDIR="$XDG_RUNTIME_DIR/app/$FLATPAK_ID"

in taskcluster/docker/thunderbird-flatpak/launch-script.sh

In order to match current flatpak: https://github.com/flathub/org.mozilla.Thunderbird/blob/master/org.mozilla.Thunderbird.json#L248

The XDG_CACHE_HOME is persistent storage while general expectation of TMPDIR is to be volatile. Shell variables should be double quoted to prevent eventual word split.

Does

if [[ "$PRODUCT" == "firefox" ]]; then

and below part in taskcluster/docker/thunderbird-flatpak/runme.sh makes sense?

While org.mozilla.firefox.BaseApp basically works a decision is needed if thunderbird should re-use firefox baseapp or make baseapp on its own and publish it on flathub. The ff baseapp lacks dependencies for playing notification sounds.

For flatpak build-finish build in taskcluster/docker/thunderbird-flatpak/runme.sh

I would consider just copying contents from https://github.com/flathub/org.mozilla.Thunderbird/blob/master/org.mozilla.Thunderbird.json#L14-L44 as those are battle-tested.

Some adjustments can be made if you find missing pieces but right now this is mixup between options copied from thunderbird and firefox and I believe some of them aren't justified, for example:

--env=GTK_PATH=/app/lib/gtkmodules

which is something ff forgot to remove when it ceased to be useful.

--device=all

which ff uses for camera/microphone access - is this relevant for thunderbird?

and so on

................

I hope something from the above is readable. I didn't find a better way to give some feedback.

Comment 3

[Rob Lemley [:rjl]]

(In reply to Emerson Bernier from comment #2)

Since phabricator doesn't allow me to submit review (what a pity) I add a poor man attempt here:

Thanks! I'll copy these into Phabricator.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/94f546210757
Implement Flatpak repackage. r=emersonbernier,rjl

Comment 5

[Daniel Darnell [:dandarnell]]

Comment on attachment 9323355 [details]
Bug 1822688 - Implement Flatpak repackage. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
User impact if declined: Testing of Thunderbird Beta Flatpak delayed
Testing completed (on c-c, etc.): on c-c version 113 (https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=3df1d8b532074889d2fe462c25282881972020bc)
Risk to taking this patch (and alternatives if risky): very low

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9323355 [details]
Bug 1822688 - Implement Flatpak repackage. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 112.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/e8b1023025d7