1822887 - [Tabs tray to Compose] Refactor unnecessary selected tabs parameters out of `SelectionMenuIntegration.handleMenuClicked` and `SelectionBannerBinding.initListeners`

Status: VERIFIED FIXED

(Fenix :: Tabs, task, P3)

Description

[Noah Bond [:007]]

The calls to the following interactor functions do not need the collection of selected tabs, as these can be readily accessed via TabsTrayState. Refactor these interactor functions (and their respective controllers/implementors) to not need this parameter and rely on TabsTrayState instead.

Do exhaustive when (item) {
        is SelectionMenu.Item.BookmarkTabs -> {
            navInteractor.onSaveToBookmarks(store.state.mode.selectedTabs)
        }
        is SelectionMenu.Item.DeleteTabs -> {
            trayInteractor.onDeleteTabs(store.state.mode.selectedTabs)
        }
        is SelectionMenu.Item.MakeInactive -> {
            trayInteractor.onInactiveDebugClicked(store.state.mode.selectedTabs)
        }
}

For SelectionBannerBinding.initListeners, the calls to navInteractor and the action dispatch for exiting selection mode should be moved to the interactor/controller.

Notes for QA:

This is a business logic refactor, so all existing functionality should be maintained with:

• Tabs tray multiselection save tabs as bookmarkss
• Tabs tray multiselection tab deletion
• Tabs tray multiselection force tabs as inactive
• Tabs tray multiselection save tabs to collections
• Tabs tray multiselection share tabs

Please validate that there have been no regressions with this functionality.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1822887 - Refactor multi selection business logic from `NavigationInteractor` to `TabsTrayController` (#1795)

Comment 2

[BMO Github Automation]

Authored by https://github.com/MozillaNoah
https://github.com/mozilla-mobile/firefox-android/commit/2551c90be982aa68716a4f5daf02180698ff2991
[main] Bug 1822887 - Refactor multi selection business logic from NavigationInteractor to TabsTrayController

Comment 3

[Andrei Mocirean]

Verified as fixed on the latest Nightly (114.0a1) from 4th of May 2023.
No issues encountered while multiple selection of tabs is performed, the tabs can be bookmarked, saved to collections, shared and marked as inactive.
Devices used for testing: Google Pixel 7 Pro (Android 13).
Thanks!