In bookmarks scrollable list/menu, the scroll arrow is partially hidden
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox111 | --- | unaffected |
firefox112 | --- | unaffected |
firefox113 | --- | verified |
firefox114 | --- | verified |
People
(Reporter: mayankleoboy1, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(6 files)
0.I have DPI=1.5 from windows and 16:10 resolution
- Create new profile
- Add the "Bookmark star button" to the bar
- Import the attached bookamrks.html
- Hover over the "misc" folder and scroll down
ER: The scroll arrow is visible
AR: The scroll arrow is partially hidden, and you cant make it visible by clicking
The STR are a liitle complicated, please see the attached video.
Regression range: Bug 1809084 - Stop using XUL layout for menu popups. r=desktop-theme-reviewers,dao,dshin
Reporter | ||
Comment 1•1 year ago
|
||
STR Video
Reporter | ||
Comment 2•1 year ago
|
||
Reporter | ||
Updated•1 year ago
|
Comment 3•1 year ago
|
||
Set release status flags based on info from the regressing bug 1809084
Assignee | ||
Comment 4•1 year ago
|
||
The arrow is visible right? It's "just" that you can't hit it.
I can repro, thanks for the STR!
Reporter | ||
Comment 5•1 year ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)
The arrow is visible right? It's "just" that you can't hit it.
I can repro, thanks for the STR!
Yes, exactly so.
I guess what i actually meant to write was that the "open all in tabs" was partially hidden, and the arrow doesnt do anything.
Assignee | ||
Comment 6•1 year ago
|
||
There are two bugs here:
-
We're sizing the popup in a way such as there's a <1px scroll range,
even though there's space to position the popup in the screen without
it. That's a layout bug I'll look into. -
When you hit that situation, we never detect that we're scrolled to
the end (because we have overflow and we're scrolled to the start
even when scrolled to the end as well).
This patch fixes the second. As per above it's not a complete fix, but
it needs fixing as well, hypothetically you could've hit this with
enough bookmarks to just hit the screen, plus 1 pixel.
I'll look into the first bug too.
Updated•1 year ago
|
Assignee | ||
Comment 7•1 year ago
|
||
Since visibility: collapse can still end up with a non-zero size for
e.g., padding and so. display: none is a better fit for this.
I noticed this while investigating the overflow mentioned in the
previous patch.
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 8•1 year ago
|
||
This is what we do for context menus, and makes more sense and
guarantees that we don't change the size of the popup (aSize) unless we
have to below.
This fixes the layout size to not fractionally shrink the popup in this
case.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fae299fc46a5 Make arrowscrollbox deal with minimal scroll area correctly. r=Gijs
Comment 10•1 year ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9196d26e6b90 Use display rather than visibility: collapse to hide scroll arrows. r=Gijs
Comment 11•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fae299fc46a5
https://hg.mozilla.org/mozilla-central/rev/9196d26e6b90
Reporter | ||
Comment 12•1 year ago
|
||
This is fixed in the latest Nightly. Thanks Emilio!
Updated•1 year ago
|
Comment 13•1 year ago
|
||
Verified issue as fixed on Win10x64 using Nightly 114.0a1(20230427095144) and 113.0b8(20230425192707).
Description
•