1823201 - In bookmarks scrollable list/menu, the scroll arrow is partially hidden

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Mayank Bansal]

Attachment: bookmarks.html

0.I have DPI=1.5 from windows and 16:10 resolution

1. Create new profile
2. Add the "Bookmark star button" to the bar
3. Import the attached bookamrks.html
4. Hover over the "misc" folder and scroll down

ER: The scroll arrow is visible
AR: The scroll arrow is partially hidden, and you cant make it visible by clicking

The STR are a liitle complicated, please see the attached video.

Regression range: Bug 1809084 - Stop using XUL layout for menu popups. r=desktop-theme-reviewers,dao,dshin

Comment 1

[Mayank Bansal]

Attachment: bandicam 2023-03-19 11-50-41-504.mp4

STR Video

Comment 2

[Mayank Bansal]

Attachment: about:support

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1809084

Comment 4

[Emilio Cobos Álvarez [:emilio]]

The arrow is visible right? It's "just" that you can't hit it.

I can repro, thanks for the STR!

Comment 5

[Mayank Bansal]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

The arrow is visible right? It's "just" that you can't hit it.

I can repro, thanks for the STR!

Yes, exactly so.
I guess what i actually meant to write was that the "open all in tabs" was partially hidden, and the arrow doesnt do anything.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1823201 - Make arrowscrollbox deal with minimal scroll area correctly. r=Gijs

There are two bugs here:

• We're sizing the popup in a way such as there's a <1px scroll range,
  even though there's space to position the popup in the screen without
  it. That's a layout bug I'll look into.

• When you hit that situation, we never detect that we're scrolled to
  the end (because we have overflow and we're scrolled to the start
  even when scrolled to the end as well).

This patch fixes the second. As per above it's not a complete fix, but
it needs fixing as well, hypothetically you could've hit this with
enough bookmarks to just hit the screen, plus 1 pixel.

I'll look into the first bug too.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1823201 - Use display rather than visibility: collapse to hide scroll arrows. r=dao,Gijs

Since visibility: collapse can still end up with a non-zero size for
e.g., padding and so. display: none is a better fit for this.

I noticed this while investigating the overflow mentioned in the
previous patch.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1823201 - Fix FlipOrResize when positioning popups at end of screen to preserve popup size properly. r=neildeakin,Gijs

This is what we do for context menus, and makes more sense and
guarantees that we don't change the size of the popup (aSize) unless we
have to below.

This fixes the layout size to not fractionally shrink the popup in this
case.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fae299fc46a5
Make arrowscrollbox deal with minimal scroll area correctly. r=Gijs

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9196d26e6b90
Use display rather than visibility: collapse to hide scroll arrows. r=Gijs

Comment 11

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/fae299fc46a5
https://hg.mozilla.org/mozilla-central/rev/9196d26e6b90

Comment 12

[Mayank Bansal]

This is fixed in the latest Nightly. Thanks Emilio!

Comment 13

[Monica Chiorean (OOO August 21st 5:30PM)]

Verified issue as fixed on Win10x64 using Nightly 114.0a1(20230427095144) and 113.0b8(20230425192707).