1809084 - bookmarks menus intermittently reset their scrollbox position to the top

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[spiderman0000111]

Steps to reproduce:

after updating to the latest version on (1/5/22)  and since that update:

bookmarks now lose track of where you left off in them if you search through them, leave them and then come back to them. this is the first time this has happened in years and it started after updating this morning. Just sharing this as probably the best feature of mozilla browsers is the ability to go through bookmarks and it not losing track of where you last left off in them. if that feature were to go away, there would be little reason for me to continue using it. could it be a temp glitch? I don't know. I only noticed this in a private session window so hopefully is resolved in next update 

edit forgot to add, this is the Nightly version browser so it's updated fairly regularly. occasionally with bugs like this

Actual results:

bookmark folders on the bookmark toolbar used to save my place where I left off scrolling through them which was useful for folders with a lot of bookmarks. after that latest update and since then, this has disappeared. every time a new tab opens or i open a new bookmark, I'm now forced to re-start scrolling through the bookmark folders all over again with each new open tab. One of the #1 reasons I use Mozilla is because they were different than all the other browsers in this way for easy bookmark viewing and finding. whatever got changed is a step backwards. and if it remains permanent I'll be forced to ditch mozilla browsers.

Expected results:

essentially prior to that latest update that broke the bookmark navigation, I was able to scroll through folders of bookmarks on my bookmark toolbar, open a link or a new tab and then later return to the bookmark folder right where I left off scrolling. hugely important feature and if removed would be the last good feature and reason to continue using Mozilla browsers.

Comment 1

[spiderman0000111]

I should add that this issue is in using Firefox Nightly. the updates on the 5th for nightly is what broke this feature and ability to continuously scroll through bookmark folders without losing my place each time I scroll through the folders.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Negritas Sergiu, Desktop QA]

Hello! I have tried to reproduce the issue with firefox 110.0a1(2023-01-05) on Ubuntu 22 but unfortunately I wasn't able to reproduce the issue on my end. Could you answer the following questions in order to futher investigate this issue.

1. Does this issue happen with a new profile? Here is a link on how to create one: https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles
2. Do you have any addons installed if so can you list them?

Comment 4

[spiderman0000111]

I'm not going to switch profiles too much hassle. what happens is, if you have a bookmark folder on the bookmark toolbar with a lot of bookmarks in it and you are scrolling through them, click on a link and/or open a new tab, it will lose track of where you were when scrolling, unless you open the folder again before the tab/link fully opens... if you don't reopen the bookmark folder before the new link/tab finishes loading the bookmark folder forces you to start at the top and scroll through them all over again. It never did this in at least 3 years of using this browser and just started doing it after the update on the 5th. so.. doing some basic math, I didn't change anything on my end at all. it was the update and something in the update that screwed this up. that's all I know and all im going to report on it. it's unfortunate for those of us with a lot of bookmarks as if it doesn't get resolved I will eventually just stop using this browser as it was the primary reason for using it.

add to this fact that nearly every time I close this browser or it attempts to close itself for updates, 99% of the time it can't or won't do it. and pops up an annoying error message. this issue has not been fixed in 5-8 years. weird. good luck. be nice if something was improved on it instead of broken more. I'm not going to reset it again or switch profiles unless I absolutely have to as it's just such a tiresome hassle to deal with. Might as well just uninstall and reinstall everything again if that's the case which I did the last problem I had. it wastes a lot of time to do so. as for the inability to reproduce and perhaps solve nothing, this is why I hesitate to even try to report these issues. every time it seems nothing can be done or figured out so what's the point? lol

Comment 5

[spiderman0000111]

additionally, even if a tab is already open and scrolling through a folder hasn't reset and is holding it's place, as soon as a new video or page loads, it once again resets back to the top of the bookmark folder you were scrolling through. very strange and unnecessary. it's like the entire bookmark folders resets every time a new page loads. #facepalm

Comment 6

[Marco Bonardo [:mak]]

Emilio, may this be related to the menuframe simplifications? From the description it sounds like we may be losing the arrowscrollbox position.
If you don't know off-hand, we'll just look for a regression range.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Maybe? Not sure off-hand tho, so a regression range would be useful. Which platform is this on? I can't repro on Linux/X11 or Windows, but I can repro on Linux/Wayland. I took a look and we size the popup to its full height and when positioning the wayland compositor constrains us. So it is expected to lose the scroll position (in the sense that the scroller becomes huge and thus it goes to zero), and I don't know why it wouldn't happen before. Anyways can look but I want to confirm that the reporter is also on Wayland.

Comment 8

[spiderman0000111]

Really gotta ask. What has Mozilla been doing with the Private browser windows??!! I mean it's one thing after another with this thing. They aren't supposed to be literally two separate browsers. Now I can't save images off a google search in a private browser session. can with every other browser and used to be able to with firefox till today. It's just weird. Come on guys. do better. please

Comment 9

[spiderman0000111]

Windows 11 latest updates. yes. before the updates, things were working relatively good. now I can't even save images off a google search. and it won't save my place in scrolling through bookmark folders UNLESS I quickly reopen the folder to hold the spot before the new tab or page loads. that is weird. never had to do that before

Comment 10

[spiderman0000111]

meaning if I search google for an image, click on the image and to the right the selected image where I was able to right click and save image the save image option is not in the context menu. this just started in today's window. only happening in the private browser window for some reason. and the private browser shortcut on my windows taskbar won't launch a private browser window anymore. it has to be launched from the primary browser window open. 🤦

Comment 11

[spiderman0000111]

so basically every update lately is breaking good basic functionality. lol unbelievable. alright. I'm out. time to move on from mozilla. it's become too much of hassle to keep using. good luck. hope you change directions.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

I can't repro that (nor the google image thing) on windows 11 either fwiw.

(In reply to spiderman0000111 from comment #10)

meaning if I search google for an image, click on the image and to the right the selected image where I was able to right click and save image the save image option is not in the context menu. this just started in today's window. only happening in the private browser window for some reason. and the private browser shortcut on my windows taskbar won't launch a private browser window anymore. it has to be launched from the primary browser window open. 🤦

Let's scope this to the bookmarks issue. It'd be great to confirm whether a new profile reproduces the issue or not tho.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 14

[spiderman0000111]

granted this is still a bookmarks/folders placement issue, but could we please just pick one when it comes to a separate private browser session window taskbar icon or a merged one with the regular browser session icon on the taskbar? It's now gone back and forth like 5-6 times throughout updating. So I've basically had to re-pin the separated private browser shortcut to windows 11 taskbar multiple times only to have it disappear into the primary shortcut window taskbar icon after updating numerous times now. Just pick a style/interface option and stick with it please. I wouldn't have brought this up here but it's seriously the 5th time now

Comment 15

[Mark Banner (:standard8)]

(In reply to spiderman0000111 from comment #14)

granted this is still a bookmarks/folders placement issue, but could we please just pick one when it comes to a separate private browser session window taskbar icon or a merged one with the regular browser session icon on the taskbar?

As you have already been asked, please stop trying to report multiple issues in a single bug. Doing so will mean that they won't get tracked and they will likely not be looked at by the correct team. Also, please take a look at the bug writing guidelines before filing your next bug, having a clearer description will make it much easier for bug triagers and developers to work on your issues.

Comment 16

[Marco Bonardo [:mak]]

I tried to reproduce the bug on Windows 10, but I don't see it.

Could you please tell us more about your system? I can't find info about the OS you are using.

If you are willing to help us findind the problem, you could try using mozregression, the page explains the basics, in practice it will download various builds and let you reproduce the bug, you just have to mark versions are good or bad, until it reaches the change that caused the bug. Then you just have to post the generated link into Bugzilla.
Since we cannot reproduce the problem, it sounds like that'd be the better path forward here.

Comment 17

[Marco Bonardo [:mak]]

We got multiple reports of this issue on Reddit and Connect, and I can intermittently reproduce with the overflow menu on the toolbar.
What I do:

1. Ensure there's many bookmarks overflowing in the toolbar
2. open the overflow menu and scroll down a bit
3. click on a bookmark
4. repeat 2 and 3 until the position resets at a certain point when reopening the menu

Comment 19

[TOG]

Same bookmark problem here. Reverts back to the top of the list after updating Firefox from 109.0.1 to 110.0 on Feb. 14,2023 and using WIN 7.
Yes I know, it's an older version, but, it still does what I need it for.
If it's not broke why fix it!

Comment 20

[Alice0775 White]

I can reproduce the issue on Nightly112.0a1 Windows10.
Screencast: https://youtu.be/q1cAKojN054

STR:

1. Set "Always Show" to Bookmarks toolbar
2. Create a folder on the Bookmarks toolbar and create a lot of bookmarks in the folder.
3. Add the following bookmark to the end of the folder
   Name : Places - A complete mess that should be dropped from FF3 - MozillaZine Forums
   URL: http://forums.mozillazine.org/viewtopic.php?t=625491&postdays=0&postorder=asc&postsperpage=15&start=90
4. Click on the folder
5. Scroll down the menupopup
6. Right(Choose Open in New Tab)/Left/Middle mouse click on the Bookmark.
7. Click on the folder again. And observe the scroll position

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0c989b2bcd7882a9e7106e7879ab8933c2e09071&tochange=47c002d3637247e71ee901f32421deaecc9d8ea3

Comment 21

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1805414

Comment 22

[Mark Banner (:standard8)]

Additional steps from bug 1817325:

1. You need a bookmarks folder in the bookmarks toolbar
2. there have to be so many bookmarks that you can scroll several times
3. scroll down to the bottom of the list
4. open a link with the scroll wheel
5. while on the new tab, open the bookmarks folder again

Actual results:

6. the folder is no longer at the end of the list but at the start
7. if you just scroll down a little now, it jumps straight to the end of the list

Expected results:

6. the folder should be at the end of the list as it was left

Emilio, please could you take another look?

Comment 26

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1809084 - Stop using XUL layout for menu popups. r=#layout!

The underlying issue here is an invalidation bug with XUL layout. When a
popup opens, we try to lay it out at full size, then post a reflow
callback to constrain it.

There's an intermediate step there where the popup might remain at full
size, and the constraining operates directly on mRect, which isn't quite
sound and doesn't update the scrollport of descendants.

Make nsMenuPopupFrame inherit from nsBlockFrame instead, doing
potentially two layout passes when constrained.

This fixes the issue at hand, and removes XUL layout from menu popups,
so it's a win-win.

To make reasoning about it a bit easier, factor out a bunch of the XUL
positioning code to be const. The mutation of mRect etc which was going
on otherwise was pretty hard to reason about.

Comment 27

[[e-mail]]

I have just started to experience this issue after today's update for Ubuntu 20.04.

Comment 29

[jscher2000]

Related Mozilla Connect thread: Bookmark error after update to version 110.0 - Mozilla Connect

Comment 30

[spiderman0000111]

so I'm glad at least others are reporting the issue to at least bring some light to what would seemingly be considered a small problem but in fact really makes life very difficult for many people in browsing bookmarks when prior to the issue, it was a feature that I think many people really do appreciate having. That being said, at least one of the updates today (and hopefully this is a temporary issue and not another bookmark bug) seems to have stopped my ability to "Open All Bookmarks" selection and the "Open All in Tabs" selection while in my bookmarks folders. Essentially, selecting EITHER of these options does absolutely nothing now. it's like the selection option was removed without removing the link in firefox. This is again firefox nightly. I don't if it's related or not. just reporting it. but if you are going through folder in bookmarks and you want to open multiple links at once? this option just literally stopped working today after updating again.

Comment 31

[spiderman0000111]

(In reply to spiderman0000111 from comment #30)

so I'm glad at least others are reporting the issue to at least bring some light to what would seemingly be considered a small problem but in fact really makes life very difficult for many people in browsing bookmarks when prior to the issue, it was a feature that I think many people really do appreciate having. That being said, at least one of the updates today (and hopefully this is a temporary issue and not another bookmark bug) seems to have stopped my ability to "Open All Bookmarks" selection and the "Open All in Tabs" selection while in my bookmarks folders. Essentially, selecting EITHER of these options does absolutely nothing now. it's like the selection option was removed without removing the link in firefox. This is again firefox nightly. I don't if it's related or not. just reporting it. but if you are going through folder in bookmarks and you want to open multiple links at once? this option just literally stopped working today after updating again.

is this really that far off topic though? it's related to the bookmarks, bookmark folders, navigating said bookmarks, and the ability to open bookmarks from the bookmark folders using the navigation and menu system of firefox's bookmark folder system. now yet another main feature has simply stopped working. so not sure who dismissed it as off topic but maybe consider possibilities of being at the very least relative before dismissing? just a suggestion. This is an actual feature built into the browser that has just suddenly stopped working. so... might actually be relevant if not related. just sayin

Comment 32

[spiderman0000111]

(In reply to spiderman0000111 from comment #31)

(In reply to spiderman0000111 from comment #30)

so I'm glad at least others are reporting the issue to at least bring some light to what would seemingly be considered a small problem but in fact really makes life very difficult for many people in browsing bookmarks when prior to the issue, it was a feature that I think many people really do appreciate having. That being said, at least one of the updates today (and hopefully this is a temporary issue and not another bookmark bug) seems to have stopped my ability to "Open All Bookmarks" selection and the "Open All in Tabs" selection while in my bookmarks folders. Essentially, selecting EITHER of these options does absolutely nothing now. it's like the selection option was removed without removing the link in firefox. This is again firefox nightly. I don't if it's related or not. just reporting it. but if you are going through folder in bookmarks and you want to open multiple links at once? this option just literally stopped working today after updating again.

is this really that far off topic though? it's related to the bookmarks, bookmark folders, navigating said bookmarks, and the ability to open bookmarks from the bookmark folders using the navigation and menu system of firefox's bookmark folder system. now yet another main feature has simply stopped working. so not sure who dismissed it as off topic but maybe consider possibilities of being at the very least relative before dismissing? just a suggestion. This is an actual feature built into the browser that has just suddenly stopped working. so... might actually be relevant if not related. just sayin

images of menu item I refer to...
https://connect.mozilla.org/t5/discussions/bookmark-error-after-update-to-version-110-0/m-p/25743/highlight/true#M10374

Comment 33

[Marco Bonardo [:mak]]

We keep one issue per bug report, if you have a problem that cannot be resolved by support.mozilla.org, feel free to file a bug report about it, commenting in another bug report won't help resolving your problem.

Comment 34

[spiderman0000111]

(In reply to Marco Bonardo [:mak] from comment #33)

We keep one issue per bug report, if you have a problem that cannot be resolved by support.mozilla.org, feel free to file a bug report about it, commenting in another bug report won't help resolving your problem.

that's cool. just filed another bug report. https://bugzilla.mozilla.org/show_bug.cgi?id=1818800

Comment 37

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c15f0fb1c923
Stop using XUL layout for menu popups. r=desktop-theme-reviewers,dao,dshin

Comment 38

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c15f0fb1c923

Comment 39

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.Also, don't forget to request an uplift for the patches in the regressions caused by this fix.
• If no, please set status-firefox112 to wontfix.

For more information, please visit auto_nag documentation.

Comment 40

[Emilio Cobos Álvarez (:emilio)]

Way too risky of a change for uplift IMO.

Comment 41

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using an old Nightly from 2023-02-15, verified that this is now fixed using latest Nightly 114.0a1 and Firefox 113.0b8 across platforms (macOS 13, Ubuntu 22.04 and Windows 10), the scroll position remains in the place where it was left the last time.

Comment 42

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1809084 - Make popups interactable even when a modal dialog is shown. r=Gijs

Otherwise they are inert (which implies pointer-events: none), but since
the popup painting escapes the usual rules it looks off.

Comment 43

[Phabricator Automation]

Comment on attachment 9380691 [details]
Bug 1809084 - Make popups interactable even when a modal dialog is shown. r=Gijs

Revision D202087 was moved to bug 1880685. Setting attachment 9380691 [details] to obsolete.