1824008 - Top_picks contextual telementry is not logged

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect)

Description

[Adrian Florinescu [:aflorinescu]]

Found in

• 112.0b2

Affected versions

• 113.0a1
• 112.0b2
• 111.0
• 110.0

Tested platforms

• Affected platforms: Windows 10, Mac 13, Ubuntu 22.04

Preconditions

• VPN connected to US
• browser.urlbar.resultMenu set to true
• browser.urlbar.quicksuggest.blockingEnabled set to true
• browser.urlbar.merino.endpointURL to https://merinopy.services.mozilla.com/api/v1/suggest
• browser.urlbar.merino.providers to adm,top_picks
• browser.urlbar.bestMatch.enabled to true
• browser.search.region to US
• browser.urlbar.quicksuggest.dataCollection.enabled to true
• browser.urlbar.bestMatch.blockingEnabled to true
• browser.ping-centre.log to true

Steps to reproduce

1. Open precondition profile.
2. Open browser console
3. Type dell into address bar
4. From the Top_picks suggestion line, click more options and choose Learn More.
   4'. From the Top_picks suggestion line, click more options and choose Dismiss.

Expected result

• In browser console contextual ping is logged for both 4 and 4' steps.

Actual result

• No contextual ping is logged

Regression range

• N/A
  Uncertain if this is a regression, since AIUI there was some work done in this area and there were multiple versions of this. Additionally mozregression returns inconsistent results and yet another problem also being the fact that the Top_picks is an region based feature.

Additional notes

• The above ping behavior doesn't seem to be related to Awesome Bar Result Menu since either disabling the feature or trying on a build that doesn't have it still doesn't generate the expected glean ping-center telemetry.
• As an example, this is the non-sponsored contextual suggest ping:

TELEMETRY PING (contextual-services): {"experiments":{},"locale":"en-US","version":"112.0","release_channel":"be321ta","match_type":"firefox-suggest","advertiser":"wikipedia","block_id":0,"improve_suggest_experience_checked":true,"position":10,"source":"remote-settings","is_clicked":false,"context_id":"{b908afd8-e8eb-4274-968d-cd00f084ceeb}"}

TELEMETRY PING (contextual-services): {"experiments":{},"locale":"en-US","version":"112.0","release_channel":"be321ta","match_type":"firefox-suggest","advertiser":"wikipedia","block_id":0,"improve_suggest_experience_checked":true,"position":10,"source":"remote-settings","iab_category":"5 - Education","context_id":"{b908afd8-e8eb-4274-968d-cd00f084ceeb}"}

Comment 1

[Nan Jiang [:nanj]]

Hey Drew, I was under the impression that we decided to only collect Glean telemetry for Navigational Top Picks, correct? If so, then this is expected.

Comment 2

[Drew Willcoxon :adw]

That's right, the custom contextual services pings are not recorded for top picks/navigational suggestions. They're only recorded for suggestions that have an advertiser set. That includes adM and expanded Wikipedia suggestions but not nav suggestions.

Sorry for not making this clear, and thanks for reporting this bug!

Comment 3

[Drew Willcoxon :adw]

To add more, in the future I don't expect that these contextual services pings will be recorded for new types of suggestions, at least not ones that do not involve partners. The purpose of these pings is to report clicks and impressions to partners. For new types of suggestions that do involve partners, it's conceivable we'll want to record these pings or maybe new similar pings.