1824018 - Delete and Junk buttons in unified toolbar are disabled (greyed out). Deselecting all messages does not disable them again.

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect, P2)

Description

Attachment: toolbar_buttons_greyed_out.png

TB113.0a1 (2023-03-22) on Linux
STR:
Unified toolbar is customized with a number of buttons - see screenshot.

Actual result:

• The Delete and Junk buttons are inactive (greyed out) when Thunderbird starts, and Inbox is selected in the folder pane.
• When different folders are selected in the folder pane, one or both buttons (Delete and/or Junk) may become active eventually. However, this isn't consistently reproducible.

Expected result:
All the buttons in the unified toolbar should be active right from the start.

Comment 1

[Thomas D. (:thomas8)]

Thanks Christian.

• It's expected for the message action buttons to be disabled when no message is selected. In case of delete, the button should be disabled only when neither a message nor a deletable folder is selected (folder must be focused, too, I think). Inbox is not a deletable folder.
• However, on 113.0a1 (2023-03-22) (64-bit), Win10, deselecting the only selected message will not disable the buttons again, which looks like a bug.

Christian, is there a scenario where are you seeing those buttons disabled in spite of a message being selected?

Comment 2

[Christian Riechers]

(In reply to Thomas D. (:thomas8) from comment #1)

• It's expected for the message action buttons to be disabled when no message is selected. In case of delete, the button should be disabled only when neither a message nor a deletable folder is selected (folder must be focused, too, I think). Inbox is not a deletable folder.

Agreed.

is there a scenario where are you seeing those buttons disabled in spite of a message being selected?

Yes, selecting one or more messages in Inbox will not activate the Delete and Junk buttons, they remain greyed out.
Selecting a deletable folder will activate the Delete button, but not the Junk button.

Comment 4

[Wayne Mery (:wsmwk)]

Better now?

Comment 5

[Christian Riechers]

(In reply to Wayne Mery (:wsmwk) from comment #4)

Better now?

No, neither in beta nor in daily.

Comment 6

[Christian Riechers]

The problem with grayed out toolbar buttons does not seem to be limited to 'Delete' and 'Junk' buttons - see https://support.mozilla.org/en-US/questions/1412059
I can confirm the following statement from the support topic:
"The only way to enable these buttons is to click away from an email or folder, and then return to that item, causing the buttons to be enabled again."

Comment 7

[Wayne Mery (:wsmwk)]

When different folders are selected in the folder pane, one or both buttons (Delete and/or Junk) may become active eventually. However, this isn't consistently reproducible.

This seems really messy, perhaps even problematic. For example I see delete enabled for Spam folder.

It's expected for the message action buttons to be disabled when no message is selected. In case of delete, the button should be disabled only when neither a message nor a deletable folder is selected (folder must be focused, too, I think). Inbox is not a deletable folder.

Right. I am concerned that we might not be blocking the deletion of non-deletable folders in all cases. I haven't done lots of testing, but at one point I was seeing a folder other than Spam for which delete was enabled.

Magnus, this isn't strictly a toolbar issue, correct?

Comment 8

[Geoff Lankow (:darktrojan)]

It is a toolbar issue. Nothing's updating the toolbar when the selection changes. I am already working on this for the Delete button so I'll look at the others too.

Comment 9

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1824018 - Fix the toolbar Delete and Junk buttons. r=aleca

This fixes both buttons to update when the selected message changes, changes the Delete label to Undelete where appropriate, and hooks the delete button to cmd_deleteMessages so it only deletes messages.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/089782a62551
Fix the toolbar Delete and Junk buttons. r=aleca

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9332305 [details]
Bug 1824018 - Fix the toolbar Delete and Junk buttons. r=aleca

[Triage Comment]
Approved for beta

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 114.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/f2d73c74660d