1824090 - Cursor does not change to the hand icon on the upper-left part of PiP first time toggle

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Peter Magyari (Desktop QA)]

Found in

• Firefox Beta 112.0b5

Affected versions

• Firefox Nightly 112.0a1

Unaffected versions

• Firefox Release/ESR

Affected platforms

• Windows 10
• MacOS 12
• Ubuntu 22.04

Steps to reproduce

1. Open Firefox using a new profile.
2. Navigate to https://www.youtube.com/watch?v=9nF0K2nJ7N8
3. Hover over the PiP-first time toggle.

Expected result

• The cursor changes to the "hand" icon over the whole surface of the expanded PiP toggle.

Actual result

• The cursor does not change to the "hand" icon on the upper-left part of the PiP toggle.

Regression range

• Will look for a regression-range ASAP.

Comment 1

[Peter Magyari (Desktop QA)]

Regression range

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2b1811ccd618dd88d3c35d665de67c55db4762d9&tochange=ee5ab15227245d75bcca777d15c6902d82bf5cc3

Seems like the issue was introduced by Bug 1811312.

Katherine, could you take a look?

Comment 2

[kpatenio]

After putting all pip-toggle related styles into pipToggle.css, it's possible that changing various rules made existing pointer-events properties override each other. It should be a matter if adjusting the pointer-events for pip-expanded and pip-explainer.

Comment 3

[kpatenio]

Attachment: Bug 1824090 - fix cursor pointer for pip-expanded toggle

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ebc3b3de74f
fix cursor pointer for pip-expanded toggle r=pip-reviewers,mhowell

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing browser-chrome failures in toolkit/components/pictureinpicture/tests/browser_toggleMode_2.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/7a0811032883802ae54b961fae5a31788a1ab3ce

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_toggleMode_2.js | Expected to get the right mouse events. - ["click"] deepEqual []

Comment 6

[kpatenio]

Removing pointer-events very likely contributed to the failures. I updated the patch to revert those changes.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e2b4acc670a
fix cursor pointer for pip-expanded toggle r=pip-reviewers,mhowell

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5e2b4acc670a

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kpatenio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox112 to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Peter Magyari (Desktop QA)]

I have verified the fix using Firefox Beta 113.0b2 on MacOS 11.6, Windows 10 and Ubuntu 20.04.

Comment 11

[Peter Magyari (Desktop QA)]

After some further testing, it looks like it has been indeed fixed on Youtube, but now the cursor does not change to the hand icon at all while hovering over the first-time-PiP toggle on several different media platforms like Netflix/Hulu/Twitch/Dailymotion. Should I log a separate bug for those or should we re-open this one?

Comment 12

[kpatenio]

(In reply to Peter Magyari (Desktop QA) from comment #11)

After some further testing, it looks like it has been indeed fixed on Youtube, but now the cursor does not change to the hand icon at all while hovering over the first-time-PiP toggle on several different media platforms like Netflix/Hulu/Twitch/Dailymotion. Should I log a separate bug for those or should we re-open this one?

Hi Peter, thanks for verifying this fix. It sounds like this new issue applies to only those sites, so I say let's file a separate bug.