1824175 - Add prompt outside of notification for users to submit crashes reports

Status: RESOLVED DUPLICATE of bug 1903335

(Fenix :: Crash Reporting, enhancement, P2)

Description

[Roger Yang [:royang]]

Currently, when a crash occurs, crash reporter depends on the notification permission to prompt the user to report crashes. However, starting Android 13, the user might not have granted us the notification permission.

Remove the dependency and prompt the user at startup if a crash has not been reported so they can perform the action there.

Comment 1

[Achintya Sharma]

Can you explain a little more about the enhancement, because I was checking the code and it seems like the crash was reported when we started the browser after it crashed.

The files I checked:
CrashReporterController.kt: The function (submitPendingNonFatalCrashesIfNecessary) is sending crash report when we start the browser and restore tabs, of course you will find some abstraction in the method while looking into it.

Comment 2

[Roger Yang [:royang]]

(In reply to Achintya Sharma from comment #1)

Can you explain a little more about the enhancement, because I was checking the code and it seems like the crash was reported when we started the browser after it crashed.

The files I checked:
CrashReporterController.kt: The function (submitPendingNonFatalCrashesIfNecessary) is sending crash report when we start the browser and restore tabs, of course you will find some abstraction in the method while looking into it.

That function is only sending Non fatal crashes (Crashes in Geckoview) and did not cause a app crash. When Firefox Android crashes, currently we use a notification to ask the user to report fatal crashes. The plan here is to prompt the user after restarts to report these fatal crashes.

Comment 3

[Chris Peterson [:cpeterson]]

The Android team has not been keeping our P1 bug list up to date, so we're resetting all our P1 bugs to P2 to avoid signalling that we're actively working on bugs that we're not. The BMO documentation https://wiki.mozilla.org/BMO/UserGuide/BugFields#priority says P1 means "fix in the current release cycle" and P2 means "fix in the next release cycle or the following (nightly + 1 or nightly + 2)".

If you are actively working on this bug and expect to ship it in Fx 122 or 123, then please restore the priority back to P1.