1824275 - When I click on the PiP button in the address bar after viewing a preview of a youtube search result video, the actual PiP window does not appear, although it is in the taskbar.

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P2)

Description

[Alice0775 White]

I found the other problem when I test Bug 1824262.

Steps To Reproduce:

1. Start Firefox with new profile(If you have played with PiP in the past, the problem does not occur).
2. Navigate to https://www.youtube.com/results?search_query=%22A+Preview+Of+Firefox+4%22
3. Hover your cursor over the thumbnail of the first search result(Non-advertising videos).
4. Wait for the preview to start playing, and PiP toggle button will appear in the Address bar.
5. Click on the PiP toggle button in the Address bar.

Actual results:
The window taskbar shows that a PiP window is open, but the actual PiP window does not appear on the desktop unless you have played video on PiP in the past .

Expected results:
PiP toggle button in the Address bar should not be enabled at step 4.

Comment 1

[Kestrel]

Attachment: Tall PiP window on Ubuntu after viewing youtube thumbnail preview

On Ubuntu 22.10 with the same STR, the PiP window appears but is extremely tall, extending the full height of the screen and more.

Comment 2

[Molly Howell (she/her) (no longer active)]

Hmm. I suspect this is happening because mousing out of the preview causes it to disappear. We'll need a way to hide the address bar button in that case.

Comment 3

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1824275 - Track all videos for PiP urlbar toggle. r=#pip-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b450a59ac591
Track all videos for PiP urlbar toggle. r=pip-reviewers,mhowell

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b450a59ac591

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:niklas, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox113 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Ardelean Oana, Desktop QA [:oardelean]]

Reproducible on a 2023-05-02 Nightly build on macOS 12.
Verified as fixed on Firefox 114.0b4(build ID: 20230514175823) and Nightly 115.0a1(build ID: 20230516212859) on macOS 12, Windows 10, Ubuntu 22.