Url bar toggle on one-video pages: open and close PiP
Categories
(Toolkit :: Picture-in-Picture, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: asafko, Assigned: niklas)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-pip3])
Attachments
(2 files)
User story
As a user, I want to have an additional entry point into Picture-in-Picture that is not positioned over the video.
Acceptance criteria
-
For pages containing one video - url bar icon opens PiP in one click.
-
Hover state text for the url bar icon: to be added shortly.
-
Once PiP window is open, the icon changes its state. If clicked again while PiP window is open, it closes the PiP window.
-
For pages containing multiple videos - url bar icon is not displayed.
Updated•5 months ago
|
Comment 3•4 months ago
|
||
Setting to P3 for now since there's not yet an assignee.
Assignee | ||
Updated•4 months ago
|
Updated•4 months ago
|
Updated•4 months ago
|
Assignee | ||
Comment 4•3 months ago
|
||
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1eee1fa2d9dd Urlbar entry point for PiP. r=cmkm,pip-reviewers,desktop-theme-reviewers,dao,mconley,fluent-reviewers,flod
Comment 6•3 months ago
|
||
Backed out changeset 1eee1fa2d9dd (bug 1811318) for causing bc failures at browser_preferences_usage.js
Backout: https://hg.mozilla.org/integration/autoland/rev/d65395a2bd805a5e66ffe91ef622c195c7a652bb
Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=1ef8b43656c1fa9eb8fd2f1bd2b6b3a61012705f
Failure log: https://treeherder.mozilla.org/logviewer?job_id=409635228&repo=autoland&lineNumber=6564
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/31492838d6cb Urlbar entry point for PiP. r=cmkm,pip-reviewers,desktop-theme-reviewers,dao,mconley,fluent-reviewers,flod
Comment 8•3 months ago
|
||
Backed out this bug for causing extremely high frequency failures on browser_urlbar_toggle.js in Bug 1823801
- backout: https://hg.mozilla.org/integration/autoland/rev/8ef87e9e86b55f75ea345c359aab38af33239119
- push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=31492838d6cb81e765d8d65a7e1ff49590f3f14a
- failure log: https://treeherder.mozilla.org/logviewer?job_id=409679292&repo=autoland&lineNumber=2808
[task 2023-03-21T21:09:13.699Z] 21:09:13 INFO - TEST-START | toolkit/components/pictureinpicture/tests/browser_urlbar_toggle.js
[task 2023-03-21T21:09:14.282Z] 21:09:14 INFO - GECKO(1646) | JavaScript error: resource://gre/modules/XULStore.sys.mjs, line 58: Error: Can't find profile directory.
[task 2023-03-21T21:09:17.258Z] 21:09:17 INFO - GECKO(1646) | console.error: (new Error("Polling for changes failed: Unexpected content-type \"text/plain;charset=US-ASCII\".", "resource://services-settings/remote-settings.sys.mjs", 325))
[task 2023-03-21T21:09:33.962Z] 21:09:33 INFO - GECKO(1646) | ALSA lib seq_hw.c:466:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory
[task 2023-03-21T21:11:14.065Z] 21:11:14 INFO - TEST-INFO | started process screentopng
[task 2023-03-21T21:11:14.566Z] 21:11:14 INFO - TEST-INFO | screentopng: exit 0
[task 2023-03-21T21:11:14.567Z] 21:11:14 INFO - Buffered messages logged at 21:09:13
[task 2023-03-21T21:11:14.569Z] 21:11:14 INFO - Entering test bound test_urlbar_toggle_multiple_contexts
[task 2023-03-21T21:11:14.570Z] 21:11:14 INFO - Buffered messages logged at 21:09:14
[task 2023-03-21T21:11:14.571Z] 21:11:14 INFO - Console message: [JavaScript Error: "Error: Can't find profile directory." {file: "resource://gre/modules/XULStore.sys.mjs" line: 58}]
[task 2023-03-21T21:11:14.571Z] 21:11:14 INFO - load@resource://gre/modules/XULStore.sys.mjs:58:15
[task 2023-03-21T21:11:14.571Z] 21:11:14 INFO - XULStore@resource://gre/modules/XULStore.sys.mjs:17:10
[task 2023-03-21T21:11:14.573Z] 21:11:14 INFO -
[task 2023-03-21T21:11:14.576Z] 21:11:14 INFO - Buffered messages logged at 21:09:20
[task 2023-03-21T21:11:14.576Z] 21:11:14 INFO - Waiting for videos to be ready
[task 2023-03-21T21:11:14.576Z] 21:11:14 INFO - Waiting for videos to be ready
[task 2023-03-21T21:11:14.577Z] 21:11:14 INFO - Waiting for 'canplaythrough' for ''
[task 2023-03-21T21:11:14.577Z] 21:11:14 INFO - Buffered messages finished
[task 2023-03-21T21:11:14.578Z] 21:11:14 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_urlbar_toggle.js | Test timed out -
[task 2023-03-21T21:11:14.580Z] 21:11:14 INFO - GECKO(1646) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2023-03-21T21:11:14.582Z] 21:11:14 INFO - GECKO(1646) | MEMORY STAT heapAllocated not supported in this build configuration.
[task 2023-03-21T21:11:14.582Z] 21:11:14 INFO - GECKO(1646) | MEMORY STAT | vsize 130552275MB | residentFast 1700MB
[task 2023-03-21T21:11:14.584Z] 21:11:14 INFO - TEST-OK | toolkit/components/pictureinpicture/tests/browser_urlbar_toggle.js | took 120393ms
[task 2023-03-21T21:11:14.585Z] 21:11:14 INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-03-21T21:11:14.586Z] 21:11:14 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_urlbar_toggle.js | Found a tab after previous test timed out: http://example.com/browser/toolkit/components/pictureinpicture/tests/test-page-multiple-contexts.html -
[task 2023-03-21T21:11:14.586Z] 21:11:14 INFO - checking window state
[task 2023-03-21T21:11:15.026Z] 21:11:15 INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-03-21T21:11:15.026Z] 21:11:15 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_urlbar_toggle.js | Uncaught exception received from previously timed out test bound test_urlbar_toggle_multiple_contexts - AbortError: Actor 'SpecialPowers' destroyed before query 'Spawn' was resolved
[task 2023-03-21T21:11:16.591Z] 21:11:16 INFO - Console message: BrowserTestUtils.withNewTab: Tab was already closed before removeTab would have been called
[task 2023-03-21T21:11:17.794Z] 21:11:17 INFO - GECKO(1646) | Completed ShutdownLeaks collections in process 1769
[task 2023-03-21T21:11:17.876Z] 21:11:17 INFO - GECKO(1646) | Completed ShutdownLeaks collections in process 1818
[task 2023-03-21T21:11:18.068Z] 21:11:18 INFO - GECKO(1646) | JavaScript error: chrome://mochikit/content/browser-test.js, line 1102: TypeError: can't access property "shift", currentScope.__tasks is null
[task 2023-03-21T21:11:18.081Z] 21:11:18 INFO - Console message: [JavaScript Error: "TypeError: can't access property "shift", currentScope.__tasks is null" {file: "chrome://mochikit/content/browser-test.js" line: 1102}]
[task 2023-03-21T21:11:18.081Z] 21:11:18 INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1114:3
[task 2023-03-21T21:11:18.081Z] 21:11:18 INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1253:14
[task 2023-03-21T21:11:18.081Z] 21:11:18 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1022:14
[task 2023-03-21T21:11:18.081Z] 21:11:18 INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1053:13
[task 2023-03-21T21:11:18.082Z] 21:11:18 INFO -
Bug 1823801 has a total of over 100+ failures:
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/06e33118ec38 Urlbar entry point for PiP. r=cmkm,pip-reviewers,desktop-theme-reviewers,dao,mconley,fluent-reviewers,flod
Comment 10•3 months ago
|
||
bugherder |
Assignee | ||
Updated•2 months ago
|
Description
•