1824374 - implement popover target attributes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[alexander :surkov (:asurkov)]

the spec is here https://html.spec.whatwg.org/multipage/popover.html#the-popover-target-attributes

It consists of parts

• [done] PopoverInvokerElement interface, bug 1823757, https://html.spec.whatwg.org/multipage/popover.html#popoverinvokerelement
• light dismiss, bug 1821732
• activation on buttons, see https://html.spec.whatwg.org/multipage/input.html#the-input-element:popover-target-attribute-activation-behavior
• algorithms:
  • popover target attribute activation behavior alg, https://html.spec.whatwg.org/multipage/popover.html#popover-target-attribute-activation-behavior
  • popover target element alg, https://html.spec.whatwg.org/multipage/popover.html#nearest-inclusive-target-popover-for-invoker

Comment 1

[alexander :surkov (:asurkov)]

(In reply to alexander :surkov (:asurkov) from comment #0)

• algorithms:
  • popover target attribute activation behavior alg, https://html.spec.whatwg.org/multipage/popover.html#popover-target-attribute-activation-behavior

bug 1826793 is filed

• popover target element alg, https://html.spec.whatwg.org/multipage/popover.html#nearest-inclusive-target-popover-for-invoker

implemented as part of bug 1821732

Comment 2

[alexander :surkov (:asurkov)]

Attachment: Bug 1824374 - implement popover activation behavior, r?emilio

See https://html.spec.whatwg.org/#the-input-element:popover-target-attribute-activation-behavior

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d030d5dc991d
implement popover activation behavior, r=emilio

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33db288f32f4
Backed out changeset d030d5dc991d for causing popover related wpt failures.

Comment 5

[alexander :surkov (:asurkov)]

Could you link please which tests failed specifically? It's weird but I had no issues locally.

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out changeset for causing popover related wpt failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d030d5dc991d5e4983450a3a894fc51d6834e4d1&selectedTaskRun=AUEe1nZ3RxeN722SdBMcow.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=412578202&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/c061ec6c908e819440f660b1cc305149d0732ff9

Comment 7

[alexander :surkov (:asurkov)]

here's an example of failures, https://treeherder.mozilla.org/logviewer?job_id=412576527&repo=autoland&lineNumber=33684

apparently I was updating wpt tests on out of date build, since the log mentions :popover-open which is not yet implemented (was backed out recently iirc). I will try to update to trunk, update wpt tests expectations and reland.

Comment 8

[Cosmin Sabou [:CosminS]]

This is how it looks on a push that runs all tests: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=fb122f5af0d770bb83c163a793b43bfb01ef2223&searchStr=wpt&test_paths=%2Fhtml%2Fsemantics%2Fpopovers&selectedTaskRun=Ztm0OA_1TbWpc5axd9HbSQ.0

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/241b4b54e654
implement popover activation behavior, r=emilio

Comment 10

[Atila Butkovits]

Backed out for causing failures at popover-invoking-attribute.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/245cac53b69012814264f7e971f9aa7d82970b1a

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=241b4b54e65456ca4bc2db8b6f2e507e6c16eb83&selectedTaskRun=ZDCh1IR4RPKSqM1hti-H_Q.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=412763350&repo=autoland&lineNumber=12303

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/525d1491fa5b
implement popover activation behavior, r=emilio

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/525d1491fa5b