1824389 - Remove _initCookieBannerHandlingLearnMore() function from privacy.js

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Tim Giles [:tgiles] | OOO Nov 24 - 28]

Since Bug 1814426 added a moz-support-link for the cookieBannerHandlingLearnMore element, we no longer need the _initCookieBannerHandlingLearnMore function. We should remove this and the call to it at L1952.

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • Here is a more detailed tutorial for getting set up to work on Firefox
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
3. Start working on this bug.
   • Remove the redundant code at https://searchfox.org/mozilla-central/rev/8e9b4484408154b80d7ede9e1b035819fda48fd2/browser/components/preferences/privacy.js#1968-1972
   • Remove the call to _initCookieBannerHandlingLearnMore() in the same privacy.js file
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
4. Build your change with mach build and verify your change with mach run and ensuring the Cookie Banner Reduction link still points to https://support.mozilla.org/en-US/kb/cookie-banner-reduction?as=u&utm_source=inproduct. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 1

[Denis Kisavi (:kisavi)]

Hello @tgiles. Can I be assigned this bug so that I can work on it? Thank you.

Comment 2

[Denis Kisavi (:kisavi)]

I have currently started looking into the bug.

Comment 3

[Tim Giles [:tgiles] | OOO Nov 24 - 28]

Sure, I've assigned it to you. Please reach out via needinfo or over on Matrix if you need additional help.

Comment 4

[Denis Kisavi (:kisavi)]

Great, thank you for assigning it to me. I'll definitely reach out if I need any additional help.

Comment 5

[Denis Kisavi (:kisavi)]

Hello Tim. I have attempted to execute the commands hg pull and hg update central, and they have completed successfully. However, upon reviewing the HTML section of the privacy.inc.xhtml , I have observed that the Bug 1814426 fix has not been updated or applied. As a result, this is impacting the functionality of my Bug 1824389 fix since the link is not being set on the element as intended. Thank you.

Comment 6

[Denis Kisavi (:kisavi)]

Hello Tim. Someone guided me on how to apply the fix. I was advised to run hg update autoland after the hg pull since the patch had been merged to the autoland repository for automated testing and not the central yet. This not only solved the issue I was having but also gave me a picture of how the merge process for this project works considering I am new to this. Thank you.

Comment 7

[Denis Kisavi (:kisavi)]

Attachment: Bug 1824389 - Remove _initCookieBannerHandlingLearnMore() function from privacy.js. r?tgiles.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/551a62ee0bdc
Remove _initCookieBannerHandlingLearnMore() function from privacy.js. r=tgiles.

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/551a62ee0bdc