1814426 - Replace "cookieBannerHandlingLearnMore" xul label with moz-support-link

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Tim Giles [:tgiles]]

The cookie banner handling label can be replaced with a moz-support-link. We should do that.

• https://searchfox.org/mozilla-central/rev/8e9b4484408154b80d7ede9e1b035819fda48fd2/browser/components/preferences/privacy.inc.xhtml#419
• https://searchfox.org/mozilla-central/rev/8e9b4484408154b80d7ede9e1b035819fda48fd2/browser/components/preferences/privacy.js#1968-1972

Comment 1

[Tim Giles [:tgiles]]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions.
3. Start working on this bug.
   • You'll need to navigate to about:preferences#privacy and scroll/find the "Cookie Banner Reduction" section.
   • The "Learn more" link here needs to be replaced with a <html:a is="moz-support-link" ...> element.
   • Make sure the link still takes you to a support.mozilla.org page after swapping in the new element.
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
4. Build your change with mach build and verify your changes by ensuring the link navigates you to https://support.mozilla.org/en-US/kb/cookie-banner-reduction (currently this page doesn't exist, don't worry about that, just make sure the URL contains the "cookie-banner-reduction" part). Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 2

[Abimbola]

I am looking into this bug and working on the next steps.

Comment 3

[Abhishek[: unavailable till 11 May]]

Sir, Can I make a patch for this, I have read the description properly, and my setup is also ready and there is no activity on this bug from last one week, so please give me a chance to give a try to this bug.

Comment 4

[Tim Giles [:tgiles]]

Abhishek, you are already assigned to 16 different bugs (11 of which are still open). You should focus on landing work first before picking up more and more bugs. It is more important to deliver quality work as opposed to a large quantity of work.

Comment 5

[Ganna]

Hi! I've noticed that there wasn't any activity on this issue for a couple of weeks, may I try to work on it?

Comment 6

[Tim Giles [:tgiles]]

Opening this back up to first-time contributors. Ganna and Abhishek, I may assign this to one of you two if there is not interest in solving this bug. For the moment, this will be reserved for someone who has not yet contributed to Firefox and wants to get started. For those interested, please comment on the bug that you wish to work on this and consult Comment #0 and Comment #1

Comment 7

[briannapatricia7]

hello, Tim, can i take over this bug and turn it into a hug instead

Comment 8

[briannapatricia7]

hello Tim, I realized the link in step 4 is broken.

4.Build your change with mach build and verify your changes by ensuring the link navigates you to https://support.mozilla.org/en-US/kb/cookie-banner-reduction (currently this page doesn't exist, don't worry about that, just make sure the URL contains the "cookie-banner-reduction" part). Also check your changes for adherence to our style guidelines by using mach lint.

Comment 9

[briannapatricia7]

Is it fine to report it as a bug, ?

Comment 10

[briannapatricia7]

sorry about this

Comment 11

[Tim Giles [:tgiles]]

Hi Brianna, the link in step 4 is expected to be broken. You do not need to file a bug for it, as we have a bug on file for it. Note: you cannot work on the linked bug, that is something that has to be handled by the Support folks, so please don't comment on Bug 1800663 asking to work that one 🙂

Comment 12

[Ebilite Uchenna]

briannapatricia: Are you still working on this bug or should I give it a try

Comment 13

[Ebilite Uchenna]

Attachment: Bug 1814426 - Replaced "cookieBannerHandlingLearnMore" xul label with moz-support-link. r?tgiles

Comment 14

[Ebilite Uchenna]

Hello tgiles,

Please overlook my submitted patch, I have been pointed to know that brianna is currently working on the task.

Sorry for the inconveniences @briannapatricia7

Comment 15

[briannapatricia7]

thanks Ebilite for the work done so far. Please take it up. thanks ..........go on with the bug

Comment 16

[Ebilite Uchenna]

Thanks alot Briannapatricia, Will take it up now

Comment 17

[Ebilite Uchenna]

Attachment: Bug 1814426 - Replaced "cookieBannerHandlingLearnMore" xul label with moz-support-link. r?tgiles

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a33a5b32b786
Replaced "cookieBannerHandlingLearnMore" xul label with moz-support-link. r=tgiles

Comment 19

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a33a5b32b786