1824465 - Require toplevel actors to be refcounted

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 1: Introduce ReleaseAssertIsOnMainThread, r=#xpcom-reviewers

This is like AssertIsOnMainThread, except with a release assert.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 2: NS_INLINE_DECL_REFCOUNTING_INHERITED should always override, r=#xpcom-reviewers

Without this change, a class with multiple base classes, one of which is
concrete, would not implement the pure virtual refcounting methods from the
other class.

Depends on D173716

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 3: Make PContent refcounted, r=#ipc-reviewers

Depends on D173717

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 4: Make PProcessHangMonitor refcounted, r=#ipc-reviewers

Depends on D173718

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 5: Make PGMP refcounted, r=#ipc-reviewers

Depends on D173719

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 6: Make PRDD refcounted, r=#ipc-reviewers

Depends on D173720

Comment 7

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 7: Make PRemoteDecoderManager refcounted, r=#ipc-reviewers

Depends on D173721

Comment 8

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 8: Make PGPU refcounted, r=#ipc-reviewers

Depends on D173722

Comment 9

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 9: Make PVsyncBridge refcounted, r=#ipc-reviewers

Depends on D173723

Comment 10

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 10: Make PCompositorManager refcounted, r=#ipc-reviewers

Depends on D173724

Comment 11

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 11: Make PImageBridge refcounted, r=#ipc-reviewers

Depends on D173725

Comment 12

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 12: Make PUICompositorController refcounted, r=#ipc-reviewers

Depends on D173726

Comment 13

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 13: Make PVideoBridge refcounted, r=#ipc-reviewers

Depends on D173727

Comment 14

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 14: Make PVR Refcounted, r=#ipc-reviewers

Depends on D173728

Comment 15

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 15: Make PVRGPU refcounted, r=#ipc-reviewers

Depends on D173729

Comment 16

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 16: Make PVRManager refcounted, r=#ipc-reviewers

Depends on D173730

Comment 17

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 17: Make ProxyAutoConfigChild refcounted, r=#ipc-reviewers

Depends on D173731

Comment 18

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 18: Make PSocketProcess refcounted, r=#ipc-reviewers

Depends on D173732

Comment 19

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 19: Make PSocketProcessBridge refcounted, r=#ipc-reviewers

Depends on D173733

Comment 20

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 20: Make PSandboxTesting refcounted, r=#ipc-reviewers

Depends on D173734

Comment 21

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 21: Make PRemoteSandboxBroker refcounted, r=#ipc-reviewers

Depends on D173735

Comment 22

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 22: Make PStreamFilter refcounted, r=#ipc-reviewers

Depends on D173736

Comment 23

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 23: Make PProfiler refcounted, r=#ipc-reviewers

Depends on D173737

Comment 24

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1824465 - Part 24: Require toplevel protocols to be refcounted, r=#ipc-reviewers!

This requires all toplevel protocols to not be [ManualDealloc], which
has been implemented in the earlier parts of this bug.

Depends on D173738

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31d6b53fdc6a
Part 1: Introduce ReleaseAssertIsOnMainThread, r=xpcom-reviewers,emilio,kmag
https://hg.mozilla.org/integration/autoland/rev/a2015d354bb1
Part 2: NS_INLINE_DECL_REFCOUNTING_INHERITED should always override, r=xpcom-reviewers,emilio,kmag
https://hg.mozilla.org/integration/autoland/rev/ef28b2777487
Part 3: Make PContent refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/d1bf32c2a6c6
Part 4: Make PProcessHangMonitor refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/563255aaa1e1
Part 5: Make PGMP refcounted, r=media-playback-reviewers,karlt
https://hg.mozilla.org/integration/autoland/rev/11ecb78ebc15
Part 6: Make PRDD refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/703599cf6189
Part 7: Make PRemoteDecoderManager refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/a69a851411f0
Part 8: Make PGPU refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/886e76bc80be
Part 9: Make PVsyncBridge refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/126773c2427a
Part 10: Make PCompositorManager refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/72049d72bcb6
Part 11: Make PImageBridge refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/de51ed5389d9
Part 12: Make PUICompositorController refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/445c5d5d9661
Part 13: Make PVideoBridge refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/92e4c6e4d73c
Part 14: Make PVR Refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/8f900395c72c
Part 15: Make PVRGPU refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/40c2467d3162
Part 16: Make PVRManager refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/3a88e4cfbe45
Part 17: Make ProxyAutoConfigChild refcounted, r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/a4238fd6b86f
Part 18: Make PSocketProcess refcounted, r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/7ef94bfa90b3
Part 19: Make PSocketProcessBridge refcounted, r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/aaa7a2c8aa3b
Part 20: Make PSandboxTesting refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/fb115ebb7fe0
Part 21: Make PRemoteSandboxBroker refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/0e6768a6419c
Part 22: Make PStreamFilter refcounted, r=extension-reviewers,kmag
https://hg.mozilla.org/integration/autoland/rev/b551b655ac72
Part 23: Make PProfiler refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/a5c8f22b7170
Part 24: Require toplevel protocols to be refcounted, r=ipc-reviewers,mccr8

Comment 27

[Noemi Erli[:noemi_erli]]

Backed out 24 changesets (Bug 1824465) for causing failures in nsISupportsImpl.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a5c8f22b7170c3fc84eb81d65d384f9c0d49407b&selectedTaskRun=BbpaSYxxQtSPHbfI2Jlmyw.0

Log: https://treeherder.mozilla.org/logviewer?job_id=411534322&repo=autoland&lineNumber=17008
https://treeherder.mozilla.org/logviewer?job_id=411538223&repo=autoland&lineNumber=8887

Backout: https://hg.mozilla.org/integration/autoland/rev/7c4504b601230399ada9facf64f99de466bc9997

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85d7e6c5e56b
Part 1: Introduce ReleaseAssertIsOnMainThread, r=xpcom-reviewers,emilio,kmag
https://hg.mozilla.org/integration/autoland/rev/b27d58d74cfd
Part 2: NS_INLINE_DECL_REFCOUNTING_INHERITED should always override, r=xpcom-reviewers,emilio,kmag
https://hg.mozilla.org/integration/autoland/rev/b643186fa325
Part 3: Make PContent refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/e4ee7bcf8600
Part 4: Make PProcessHangMonitor refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/301f18962c4b
Part 5: Make PGMP refcounted, r=media-playback-reviewers,karlt
https://hg.mozilla.org/integration/autoland/rev/e25b1eee01d1
Part 6: Make PRDD refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/fc8844ea55de
Part 7: Make PRemoteDecoderManager refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/38675392b26c
Part 8: Make PGPU refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/59b46a00fe22
Part 9: Make PVsyncBridge refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/d9c47bc7669a
Part 10: Make PCompositorManager refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/77467f706d40
Part 11: Make PImageBridge refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/d7eb9e7a3be7
Part 12: Make PUICompositorController refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/c7e08600e019
Part 13: Make PVideoBridge refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/c0991f0f3242
Part 14: Make PVR Refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/63b3cc2ab213
Part 15: Make PVRGPU refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/1bdc4e0bede3
Part 16: Make PVRManager refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/e68330b08e0c
Part 17: Make ProxyAutoConfigChild refcounted, r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/4ff19f0bf0f4
Part 18: Make PSocketProcess refcounted, r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/59e23a052737
Part 19: Make PSocketProcessBridge refcounted, r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/2bb63c7bcabd
Part 20: Make PSandboxTesting refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/95252be7d1c4
Part 21: Make PRemoteSandboxBroker refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/c44c6d52092e
Part 22: Make PStreamFilter refcounted, r=extension-reviewers,kmag
https://hg.mozilla.org/integration/autoland/rev/55bc5fc09546
Part 23: Make PProfiler refcounted, r=ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/e32ac9fc4d83
Part 24: Require toplevel protocols to be refcounted, r=ipc-reviewers,mccr8

Comment 29

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/85d7e6c5e56b
https://hg.mozilla.org/mozilla-central/rev/b27d58d74cfd
https://hg.mozilla.org/mozilla-central/rev/b643186fa325
https://hg.mozilla.org/mozilla-central/rev/e4ee7bcf8600
https://hg.mozilla.org/mozilla-central/rev/301f18962c4b
https://hg.mozilla.org/mozilla-central/rev/e25b1eee01d1
https://hg.mozilla.org/mozilla-central/rev/fc8844ea55de
https://hg.mozilla.org/mozilla-central/rev/38675392b26c
https://hg.mozilla.org/mozilla-central/rev/59b46a00fe22
https://hg.mozilla.org/mozilla-central/rev/d9c47bc7669a
https://hg.mozilla.org/mozilla-central/rev/77467f706d40
https://hg.mozilla.org/mozilla-central/rev/d7eb9e7a3be7
https://hg.mozilla.org/mozilla-central/rev/c7e08600e019
https://hg.mozilla.org/mozilla-central/rev/c0991f0f3242
https://hg.mozilla.org/mozilla-central/rev/63b3cc2ab213
https://hg.mozilla.org/mozilla-central/rev/1bdc4e0bede3
https://hg.mozilla.org/mozilla-central/rev/e68330b08e0c
https://hg.mozilla.org/mozilla-central/rev/4ff19f0bf0f4
https://hg.mozilla.org/mozilla-central/rev/59e23a052737
https://hg.mozilla.org/mozilla-central/rev/2bb63c7bcabd
https://hg.mozilla.org/mozilla-central/rev/95252be7d1c4
https://hg.mozilla.org/mozilla-central/rev/c44c6d52092e
https://hg.mozilla.org/mozilla-central/rev/55bc5fc09546
https://hg.mozilla.org/mozilla-central/rev/e32ac9fc4d83