1838584 - Busted build on ppc64le due to undefined reference to `mozilla::ProfilerParent::~ProfilerParent()'

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P1)

Description

[msirringhaus]

When trying to build FF115, I encountered the following problem, though the same issue seems to still be present in trunk:
Gecko Profiler is not enabled for ppc64, but it still implements a stub of ProfilerParent, which declares a destructor, but only has an implementation behind #ifdef MOZ_GECKO_PROFILER.

Thus leading to undefined reference to mozilla::ProfilerParent::~ProfilerParent(), when trying to build.

We had this problem at SUSE, but Fedora currently disabled ppc64 because of the same problem.

I'll be submitting a potential fix shortly.

Comment 1

[msirringhaus]

Attachment: Bug 1838584 - Implement stripped down destructor for ProfilerParent, if MOZ_GECKO_PROFILER is undefined. r=mstange

On platforms such as ppc64, MOZ_GECKO_PROFILER is not defined, leading to a busted build.
The destructor-implementation was hidden behind an MOZ_GECKO_PROFILER-ifdef.

Comment 2

[Mike Hommey [:glandium]]

This seems like a regression from bug 1824465, did it not happen in 114?

Comment 3

[msirringhaus]

The RedHat-bugreport is filed for 114.
I'm not sure on our side, but I guess it did also happen.

There are two problems on ppc64.
I had a busted build on 114, but that was Bug 1775202, which is also still present on 115.
Using that, plus this patch here, I get a building version (but in the meantime, I updated to 115 beta, so I don't know for certain regarding 114).

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1824465

Comment 5

[msirringhaus]

Since you approved the patch, could you land it (I'm not able to)?
And is it possible to uplift to 115 beta as well? Would be nice to have this in before the release.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/caf02cdd3199
Implement stripped down destructor for ProfilerParent, if MOZ_GECKO_PROFILER is undefined. r=mstange

Comment 7

[Dan Horák]

+1, I came up with the same fix :-)

Comment 8

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Comment on attachment 9339232 [details]
Bug 1838584 - Implement stripped down destructor for ProfilerParent, if MOZ_GECKO_PROFILER is undefined. r=mstange

Beta/Release Uplift Approval Request

• User impact if declined: Tier 3 platforms won't be able to build Firefox.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: -
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's an ifdef change that only affects our tier 3 platforms where MOZ_GECKO_PROFILER is not defined. Tier 1-2 platforms are not affected.
• String changes made/needed: -
• Is Android affected?: No

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/caf02cdd3199

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9339232 [details]
Bug 1838584 - Implement stripped down destructor for ProfilerParent, if MOZ_GECKO_PROFILER is undefined. r=mstange

Approved for 115.0b8.

Comment 11

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d80d61687ffc