Closed Bug 1824591 Opened 2 years ago Closed 1 years ago

Convert toolkit/components/promiseworker to ES modules

Categories

(Toolkit :: Async Tooling, task, P3)

task

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

(Whiteboard: [esmification-timeline])

Attachments

(1 file)

As part of the ongoing work we should convert the files in toolkit/components/promiseworker to ES modules.

As these are used in workers, this work is currently blocked until we have support for ES modules in worker shipping to release (bug 1812591).

Severity: -- → N/A
Priority: -- → P3
Depends on: 1834360

I was wrong, this code isn't used in workers, but generates a worker itself.

No longer depends on: 1812591, 1834360
Assignee: nobody → standard8
Status: NEW → ASSIGNED

(In reply to Mark Banner (:standard8) from comment #1)

I was wrong, this code isn't used in workers, but generates a worker itself.

To support ESM ChromeWorkers, could you update the PromiseWorker utility to accept a parameter to specify the module type? I.e. set the option that was introduced in bug 1834360, at https://searchfox.org/mozilla-central/rev/603b9fded7a11ff213c0f415198cd637b7c86614/toolkit/components/promiseworker/PromiseWorker.jsm#189

(Maybe in a follow-up or a patch to this bug?)

(In reply to Rob Wu [:robwu] from comment #3)

To support ESM ChromeWorkers, could you update the PromiseWorker utility to accept a parameter to specify the module type? I.e. set the option that was introduced in bug 1834360, at https://searchfox.org/mozilla-central/rev/603b9fded7a11ff213c0f415198cd637b7c86614/toolkit/components/promiseworker/PromiseWorker.jsm#189

I filed bug 1835279 as I suspect it isn't as simple as only specifying a parameter. I'm not planning on working on it at the moment, as I'm concentrating on other items. This was just one bug I'd realised was set up wrong.

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/02dc223912e0 Convert toolkit/components/promiseworker to ES modules. r=kpatenio
Status: ASSIGNED → RESOLVED
Closed: 1 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
See Also: → 1835772
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: