1824594 - Setting ComposeDetails.customHeaders purges other non-custom headers

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Frederick Zhang]

Steps to reproduce:

Reply to an email thread, while the compose window is open, save it as a draft.

View the draft's source, can see headers like Content-Language, References, In-Reply-To.

let composeDetails = await messenger.compose.getComposeDetails(tabId)
composeDetails.customHeaders
// shows Array []
await messenger.compose.setComposeDetails(tabId, composeDetails)

Save the email again, and view the new draft's source.

Actual results:

Content-Language, References, In-Reply-To are gone.

According to the original report I got at https://github.com/Frederick888/external-editor-revived/issues/110, it doesn't have to go through the Save as Draft step actually, I just haven't found a place to experiment this.

Expected results:

Non-custom headers are not affected by ComposeDetails.customHeaders.

Comment 1

[Alfred Peters [:infofrommozilla]]

Sorry, I got that wrong.

Comment 2

[John Bieling (:TbSync)]

Attachment: Bug 1824594 - ComposeDetails.customHeaders must not purge other non-custom headers. r=#thunderbird-reviewers

Comment 3

[John Bieling (:TbSync)]

Thanks for reporting this. Submitted a fix.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a91e54e0abeb
ComposeDetails.customHeaders must not purge other non-custom headers. r=leftmostcat