1824871 - `GPURenderPassEncoder.end` and `GPUComputePassEncoder.end` renamed from `endPass`

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect, P1)

Description

[Jim Blandy :jimb]

The methods for finishing recording render and compute passes were renamed from endPass to end in gpuweb#2560. Firefox's WebIDL needs to be updated.

Comment 1

[Jim Blandy :jimb]

Attachment: Bug 1824871: Rename endPass -> end on GPURenderPassEncoder, GPUComputePassEncoder.

These were renamed in gpuweb#2560.

Comment 2

[Jim Blandy :jimb]

Patch left as draft until CTS expectation metadata is updated.

Comment 3

[Jim Blandy :jimb]

try push: https://treeherder.mozilla.org/jobs?repo=try&revision=1ffd26b5ea7e47da711498eb6f0642f8f9db58a0

Comment 4

[Erich Gubler [:ErichDonGubler]]

:jimb: The Try push looks pretty clean! Anything keeping the patch from reviewability still? r=me, if not. :)

Comment 6

[Jim Blandy :jimb]

That try push didn't run any WebGPU web platform tests. :(

New mach try fuzzy push with query 'web-platform-tests !tsan !asan !macos !android:
https://treeherder.mozilla.org/jobs?repo=try&revision=299a4c27076303a638fa4c9ec18200e2b3848776

Comment 7

[Jim Blandy :jimb]

That try push doesn't show any unexpected passes, as far as I can tell, so I'm just going to proceed with landing this and see how it goes.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5db5e441eb5f
Rename endPass -> end on GPURenderPassEncoder, GPUComputePassEncoder. r=webidl,webgpu-reviewers,teoxoy,smaug

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5db5e441eb5f

Comment 10

[Jim Blandy :jimb]

(deleted; commented on wrong bug)

Comment 11

[Jim Blandy :jimb]

(deleted; commented on wrong bug)