Closed Bug 1824876 Opened 2 years ago Closed 1 years ago

Integrate newtab linters with mach lint and phabricator SCA

Categories

(Firefox :: Messaging System, task, P4)

Product:
Firefox
Component:
Messaging System
Type:
task

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: aminomancer, Unassigned)

References

(Blocks 1 open bug)

Details

Possibly related to bug 1810365, though I suspect this one (just linting) is probably easier.

Investigate how we can integrate the linting scripts in our newtab package.json with mach, so that they can be run via mach commands, and more importantly so that they can be run automatically when relevant diffs are submitted to phabricator. The automatic linting comments from the phab reviewbot are really useful and have helped me catch many issues like extra whitespace that I otherwise wouldn't have caught before landing. So getting that to run on new revisions automatically would be really cool.

Priority: -- → P4

Fixed by bug 1832765

Status: NEW → RESOLVED
Closed: 1 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.