1832765 - Merge newtab stylelint configuration into the main configuration

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[:Gijs (he/him)]

When we added the global stylelint linter, we noticed there are already 2 smaller consumers specific to newtab and debugger code.

Right now the mach lint job enforces its smaller set of rules across the tree, and ignores these configs, leaving them in place for existing infrastructure to use.

We should merge the configs into the main job using overrides instructions, and (where needed) remove duplicate effort to lint the same files.

I know that the newtab code runs stylelint itself as part of https://searchfox.org/mozilla-central/source/browser/components/newtab/bin/try-runner.js and using an npm script, which would need adjusting. Nicolas, do you know if the debugger code also has infrastructure to run stylelint, or was it just dependent on people doing this themselves locally?

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

stylint was removed from the debugger in Bug 1669592, I guess we forgot to remove .stylelintignore and .stylelintrc
I'll take care of this (I guess in another bug maybe? and we keep this one for newtab)

Comment 2

[:Gijs (he/him)]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #1)

stylint was removed from the debugger in Bug 1669592, I guess we forgot to remove .stylelintignore and .stylelintrc
I'll take care of this (I guess in another bug maybe? and we keep this one for newtab)

Thanks for the quick response! Yes, that sounds reasonable then. I previously filed bug 1831302 which may be useful for this. I can probably submit the patch if you like...

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1832765 - fix path globbing for extensions in stylelint linter and fix debugger styles that this starts noticing, r?Standard8!,#devtools-reviewers!

For some reason I didn't fully apply the suggestion in
https://phabricator.services.mozilla.com/D177477#inline-983366
and this is affecting some invocations of stylelint (but not others, for
reasons I don't fully understand). This commit both fixes this oversight and
fixes up some debugger styles that get flagged now that they're linted
appropriately.

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1832765 - start linting scss across the tree in our standard config, r?Standard8!

Depends on D178531

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1832765 - merge new tab linting into main stylelint config, r?Standard8!,aminomancer!

Depends on D178532

Comment 6

[Phabricator Automation]

Comment on attachment 9334992 [details]
Bug 1832765 - fix path globbing for extensions in stylelint linter and fix debugger styles that this starts noticing, r?Standard8!,#devtools-reviewers!

Revision D178531 was moved to bug 1834499. Setting attachment 9334992 [details] to obsolete.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/725f62a29b02
start linting scss across the tree in our standard config, r=Standard8
https://hg.mozilla.org/integration/autoland/rev/87ce5c00c78b
merge new tab linting into main stylelint config, r=Standard8,aminomancer

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/725f62a29b02
https://hg.mozilla.org/mozilla-central/rev/87ce5c00c78b