1825006 - FileSystemFileHandle.getFile() returns an object with an incorrect file name

Status: RESOLVED FIXED

(Core :: DOM: File, defect)

Description

[[:use-strict]]

Steps to reproduce:

await (async () => {
let dir = await navigator.storage.getDirectory();
let handle = await dir.getFileHandle("test.txt", { create: true });
let file = await handle.getFile();
console.log(handle.name); // test.txt
console.log(file.name); // 6NW2MUFR2JJZN5PNB5FZHYHBA4YNR6GLKVG5YJ42QVY5KIY6XVAA
})()

Actual results:

An incorrect file name is returned, probably an internal hash of some sort

Expected results:

The File object should have the correct file name set (test.txt)

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

This happens indeed and is different from Blink behavior, are we generating a random name here?

Comment 2

[Jan Varga [:janv]]

I think we need to use a different constructor here: https://searchfox.org/mozilla-central/rev/82828dba9e290914eddd294a0871533875b3a0b5/dom/fs/parent/FileSystemManagerParent.cpp#282
A constructor which also takes a name.

Comment 3

[Jari Jalkanen]

Attachment: Bug 1825006 - Fix incorrect OPFS file names. r=#dom-storage

Comment 4

[Jari Jalkanen]

Attachment: Bug 1825006 - Test attributes of OPFS getFile results. r=#dom-storage

Depends on D174648

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad591d5cd205
Fix incorrect OPFS file names. r=dom-storage-reviewers,saschanaz,janv
https://hg.mozilla.org/integration/autoland/rev/2e885eab12b3
Test attributes of OPFS getFile results. r=saschanaz

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39408 for changes under testing/web-platform/tests

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ad591d5cd205
https://hg.mozilla.org/mozilla-central/rev/2e885eab12b3

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot