1826780 - Determine type of OPFS file objects

Status: RESOLVED FIXED

(Core :: DOM: File, task, P3)

Description

[Jari Jalkanen [:jari]]

According to the getFile spec, type attribute of file objects is set to an implementation defined value.

Currently, OPFS is not setting it at all as it needs to be deduced from the name based on some rules.

Since type is already set for the other file objects, OPFS should presumably set the type using the same parsing mechanism.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

With the fix in bug 1825006 we hit FileBlobImpl::GetTypeInternal, but then fails to call the mime service because we are not in the worker nor in the main thread:

https://searchfox.org/mozilla-central/rev/9e3413f54ed6c9165b5659558091d766d34a731f/dom/file/FileBlobImpl.cpp#205

The potential fix is to get a non-worker Runnable and dispatch it to the main thread, but that can block this thread as this is synchronous. Does this sound good to you?

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Another way is to do the same in MakeResolution(). I'd prefer that to be less obtrusive.

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Yet another way is to not depend on the OS here, which sounds more ideal to me for this API.

Comment 4

[Jari Jalkanen [:jari]]

Attachment: Bug 1826780 - Use ContentType instead of nsString as OPFS file type. r=#dom-storage

Comment 5

[Jari Jalkanen [:jari]]

Attachment: Bug 1826780 - Obtain content type from filename. r=#dom-storage

Depends on D175366

Comment 6

[Jari Jalkanen [:jari]]

Attachment: Bug 1826780 - Test content type of OPFS files. r=#dom-storage

Depends on D175367

Comment 7

[Jari Jalkanen [:jari]]

Attachment: Bug 1826780 - Support content type change on rename. r=#dom-storage

Depends on D175367

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93bc4e11ec3c
Use ContentType instead of nsString as OPFS file type. r=dom-storage-reviewers,janv

Comment 9

[Natalia Csoregi [:nataliaCs]]

Backed out with Bug 1828400 for causing bustage on QuotaCommon.h

• backout: https://hg.mozilla.org/integration/autoland/rev/e6d0b577a28c93ed650b0425edd3062e7399e5f6

Comment 10

[Jari Jalkanen [:jari]]

Attachment: Bug 1826780 - Interface with rust mime guess crate. r=#dom-storage

Depends on D175366

Comment 11

[Jari Jalkanen [:jari]]

Attachment: Bug 1826780 - Introduce content type guessing function. r=#dom-storage

Depends on D177013

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5b9f13d3aad
Use ContentType instead of nsString as OPFS file type. r=dom-storage-reviewers,janv

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f5b9f13d3aad

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e36ac535bad6
Interface with rust mime guess crate. r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/06078bc0975d
Introduce content type guessing function. r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/8a64c9809f20
Obtain content type from filename. r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/d21bc1f962ff
Support content type change on rename. r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/d6a5c60d7903
Test content type of OPFS files. r=dom-storage-reviewers,janv

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e36ac535bad6
https://hg.mozilla.org/mozilla-central/rev/06078bc0975d
https://hg.mozilla.org/mozilla-central/rev/8a64c9809f20
https://hg.mozilla.org/mozilla-central/rev/d21bc1f962ff
https://hg.mozilla.org/mozilla-central/rev/d6a5c60d7903