1825033 - Badge descriptions should not use brand-product-name, but hardcode Mozilla

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Pier Angelo Vendrame]

Some addon badges use strings that does not make clear who reviewed/recommends the extension:

addon-badge-recommended2 =
  .title = { -brand-product-name } only recommends extensions that meet our standards for security and performance
addon-badge-verified2 =
  .title = This extension has been reviewed to meet our standards for security and performance

So, forks with a different branding will say that they are recommending the extensions.

Could this be changed to Mozilla, instead, like addon-badge-line3 (as done in Bug 1687375)?

Thanks

Comment 1

[William Durand [:willdurand]]

I remember we did that for a few strings in the past. It's likely that we didn't fix the pre-existing ones.

:flod WDYT?

Comment 2

[Francesco Lodolo [:flod]]

It's OK to hardcode a brand name if that's not supposed to change in forks (that's the case, for example, for strings around certificate authorities, where Mozilla is used). Note that -brand-product-name in the string would map to Firefox, not Mozilla.

So, that's a product decision, and it's technically possible. For that, we need to:

• Use a new string ID.
• Add an exception in the linter.

So, forks with a different branding will say that they are recommending the extensions.

Do forks have the extension recommendation system enabled? If that's the case, could they have different suggestions than standard Firefox?

Comment 3

[Pier Angelo Vendrame]

(In reply to Francesco Lodolo [:flod] from comment #2)

So, forks with a different branding will say that they are recommending the extensions.

Do forks have the extension recommendation system enabled? If that's the case, could they have different suggestions than standard Firefox?

For Tor Browser, we recommend users not to install extensions, to avoid changing their fingerprint, but we still keep the addons support enabled. (I do not even know if it can be disabled at build time, but we need it in any case, because of NoScript).
In addition to that, we have decided to keep the recommendation badge anyway, since AMO reviews are very useful, but we have decided to change its text downstream, to make it less ambiguous for our users ({ -brand-product-name } with Mozilla, and our with their), and we think other forks could appreciate this, too.

Comment 4

[Rob Wu [:robwu]]

Let's fix this before the next ESR, since Tor branches off ESR.

Comment 5

[Francesco Lodolo [:flod]]

BTW, I think one thing to clarify is if this should say "Firefox" or "Mozilla".

Comment 6

[Henry Wilkes (they/them) [:henry-x]]

@flod are you still interested in a fix in mozilla-central for this issue?

Would you like a patch to be submitted by one of us from Tor Project?

Comment 7

[Francesco Lodolo [:flod]]

This is really a question for TOR or Add-ons folks, since it doesn't have practical impact on official Firefox builds.

Comment 8

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1825033 - Change the firefox addon strings to work for forks. r=#fluent-reviewers,flod

We do not want to imply that Firefox forks perform this verification or
recommendation.

Comment 9

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #5)

BTW, I think one thing to clarify is if this should say "Firefox" or "Mozilla".

This is still not answered.

I'm not in a position to decide if these strings should talk about Firefox or Mozilla, because that's a content/product decision. Hopefully add-ons folks have the right contacts.

Comment 10

[Henry Wilkes (they/them) [:henry-x]]

I'm not in a position to decide if these strings should talk about Firefox or Mozilla, because that's a content/product decision. Hopefully add-ons folks have the right contacts.

Sorry, I misunderstood and thought you were just undecided yourself. I'll mark the patch as "WIP" until we get some feedback.

Comment 11

[Francesco Lodolo [:flod]]

Talked with the team, the decision is to only replace { -brand-product-name } with Firefox, and leave everything else unchanged.

Comment 12

[Henry Wilkes (they/them) [:henry-x]]

Talked with the team, the decision is to only replace { -brand-product-name } with Firefox, and leave everything else unchanged.

Thanks for clarifying. I think if the strings remain with "Firefox" and "our" then I think we'll need to replace the strings anyway in Tor Browser.

I guess for other forks, the hard-coded "Firefox" is still be better than using the brand name, since it would flag this for them. The following string would still be problematic for forks:

This extension has been reviewed to meet our standards for security and performance

since the "our" does not have a "Firefox" to refer to. Can it be changed to something like

This extension has been reviewed for Firefox to meet our standards for security and performance

or is that WONTFIX?

Comment 13

[Francesco Lodolo [:flod]]

Checking internally. Would removing "our" work?

Comment 14

[Manuel Bucher [:manuel] {{ fyi: PTO Dec 20 - Jan 4 }}]

Adding some tags for more context & updating needinfo to reflect current wait on information

Comment 15

[Henry Wilkes (they/them) [:henry-x]]

Would removing "our" work?

Yes, the "our" in addon-badge-recommended3 and addon-badge-verified3 refer to the wrong entity in the context of a fork. In our case, it implies that Tor Project has done this work and recommendation.

{ -brand-product-name } only recommends extensions that meet our standards for security and performance

This extension has been reviewed to meet our standards for security and performance

Comment 16

[Francesco Lodolo [:flod]]

UX says they're OK with removing our, so

{ -brand-product-name } only recommends extensions that meet standards for security and performance
This extension has been reviewed to meet standards for security and performance

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f3e7653d79d
Change the firefox addon strings to work for forks. r=flod,fluent-reviewers

Comment 18

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3f3e7653d79d