1825033 - Badge descriptions should not use brand-product-name, but hardcode Mozilla

Status: NEW

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Pier Angelo Vendrame]

Some addon badges use strings that does not make clear who reviewed/recommends the extension:

addon-badge-recommended2 =
  .title = { -brand-product-name } only recommends extensions that meet our standards for security and performance
addon-badge-verified2 =
  .title = This extension has been reviewed to meet our standards for security and performance

So, forks with a different branding will say that they are recommending the extensions.

Could this be changed to Mozilla, instead, like addon-badge-line3 (as done in Bug 1687375)?

Thanks

Comment 1

[William Durand [:willdurand]]

I remember we did that for a few strings in the past. It's likely that we didn't fix the pre-existing ones.

:flod WDYT?

Comment 2

[Francesco Lodolo [:flod]]

It's OK to hardcode a brand name if that's not supposed to change in forks (that's the case, for example, for strings around certificate authorities, where Mozilla is used). Note that -brand-product-name in the string would map to Firefox, not Mozilla.

So, that's a product decision, and it's technically possible. For that, we need to:

• Use a new string ID.
• Add an exception in the linter.

So, forks with a different branding will say that they are recommending the extensions.

Do forks have the extension recommendation system enabled? If that's the case, could they have different suggestions than standard Firefox?

Comment 3

[Pier Angelo Vendrame]

(In reply to Francesco Lodolo [:flod] from comment #2)

So, forks with a different branding will say that they are recommending the extensions.

Do forks have the extension recommendation system enabled? If that's the case, could they have different suggestions than standard Firefox?

For Tor Browser, we recommend users not to install extensions, to avoid changing their fingerprint, but we still keep the addons support enabled. (I do not even know if it can be disabled at build time, but we need it in any case, because of NoScript).
In addition to that, we have decided to keep the recommendation badge anyway, since AMO reviews are very useful, but we have decided to change its text downstream, to make it less ambiguous for our users ({ -brand-product-name } with Mozilla, and our with their), and we think other forks could appreciate this, too.

Comment 4

[Rob Wu [:robwu]]

Let's fix this before the next ESR, since Tor branches off ESR.

Comment 5

[Francesco Lodolo [:flod]]

BTW, I think one thing to clarify is if this should say "Firefox" or "Mozilla".