1825092 - Pulsebot should comment the changeset hash of the landed changesets to the bug for uplift landings

Status: RESOLVED FIXED

(Conduit :: Pulsebot, task, P3)

Description

[Connor Sheehan [:sheehan]]

After an uplift patch lands on a release train, Lando should comment a link to the landed patch on the bug and mark the comment with the uplift tag.

Comment 1

[Connor Sheehan [:sheehan]]

glob and I discussed this briefly yesterday. We already have pulsebot commenting on public bugs for landings to autoland. To keep things consistent, we should extend this capability into pulsebot. To summarize:

• Pulsebot should be able to comment on private bugs using a similar technique as Lando for accessing private bugs.
• Pulsebot should be able to detect when a landing is an uplift, by checking that the first line of the commit message contains a=someone.
• Pulsebot should leave comments on the bug with links to the uplifted revisions, and tag the comments it leaves with the uplift tag. See https://bugzilla.mozilla.org/show_bug.cgi?id=1818762#c28 as an example.

Once this work is completed and pulsebot can make uplift comments on bugs, it should be trivial to extend pulsebot to leave comments on sec-bugs for landings to autoland as well.

Comment 2

[Connor Sheehan [:sheehan]]

dkl is going to take this on after their current line of work is resolved.

Comment 3

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1825092 - Pulsebot should comment the changeset hash of the landed changesets to the bug for uplift landings (#2053)

Comment 4

[David Lawrence [:dkl]]

The BMO part needed for this has landed
https://github.com/mozilla-bteam/bmo/commit/3cd5a8b0a669c5852989a431ebe98770c9056a4a

The Pulsebot side of things should be done soon. Leaving bug open until that part is deployed as well.

Comment 5

[David Lawrence [:dkl]]

I notice that some uplift comments also have additional tags set and also status flags at the same time. For example, https://bugzilla.mozilla.org/show_bug.cgi?id=1829403#c37

Ryan sets the bugherder comment tag as well as the status-firefox113 to fixed.

Just to clarify, this change requirement should only be responsible for adding a comment with the revision link and the uplift comment tag and nothing else. Or should it also do the other changes as well? Will Ryan still need to make another comment manually with the other two changes?

Thanks

Comment 6

[:glob ✱]

The bugherder tag is because that's the tool that was used; we shouldn't be setting that comment tag.

Comment 7

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request

Comment 8

[David Lawrence [:dkl]]

Merged pulsebot side of things
https://github.com/mozilla-conduit/pulsebot/commit/bc79976eb9240a5aa22a28cb776f4289343b317f

Will schedule roll out next week.

Comment 9

[David Lawrence [:dkl]]

This was rolled out to production by mistake (bug 1836862) on June 5th and reports came in that pulsebot was not updating bugs. Even with the new code on production and minus the config changes, normal pulsebot messages should have still worked. Not uplift of course (need the config changes for that). But the new code uses the updated pulsebot/lando API endpoints for all operations instead of the standard API. The new endpoint for getting comments was getting errors in the log (401 Unauthorized) but the same call the the standard endpoint works fine. Sheehan reports that the Lando endpoints are working fine in Lando production. Lando is not using the get_comments() code which Pulsebot does use and is the point of failure. Will debug some more on pulsebot-dev and see why the 401 errors.

Comment 10

[David Lawrence [:dkl]]

(In reply to David Lawrence [:dkl] from comment #9)

This was rolled out to production by mistake (bug 1836862) on June 5th and reports came in that pulsebot was not updating bugs. Even with the new code on production and minus the config changes, normal pulsebot messages should have still worked. Not uplift of course (need the config changes for that). But the new code uses the updated pulsebot/lando API endpoints for all operations instead of the standard API. The new endpoint for getting comments was getting errors in the log (401 Unauthorized) but the same call the the standard endpoint works fine. Sheehan reports that the Lando endpoints are working fine in Lando production. Lando is not using the get_comments() code which Pulsebot does use and is the point of failure. Will debug some more on pulsebot-dev and see why the 401 errors.

This ended up being an elusive but simple issue that is now fixed. I will have dlactin push the new image to production today. The config changes have already been in place so it should just start working. Fingers crossed.

Comment 11

[David Lawrence [:dkl]]

The simple fix was not the only issue. After noticing errors in the log from another problem, I rolled back to previous Pulsebot image so as not to cause any problems. I am working through the new error now. This is difficult to test except with live data due to the fact that all of the bug ids in the commit messages of hg pushes do not exist on our test server (bugzilla-dev). Connor mentioned we can create a test repo on hg and have a dev pulsebot watching that repo and that way we can test with actual bugs on bugzilla-dev.

Comment 12

[David Lawrence [:dkl]]

Ok the latest fixes are now live on production and seem to be working as expected. Closing this and will open new bugs if any errors are encountered.