1825126 - Actually implement `onInstallPermissionRequest()` in `WebExtensionSupport`

Status: VERIFIED FIXED

(Firefox for Android :: WebExtensions, enhancement, P3)

Description

[William Durand [:willdurand]]

Instead of showing the permission prompt before the install starts and unconditionally returning true in WebExtensionDelegate.onInstallPermissionRequest(), we should show a prompt only when this method has been called.

This is essentially "inverting" the current install flow.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1825126 - Implement onInstallPermissionRequest in WebExtensionSupport (#2268)

Comment 2

[BMO Github Automation]

Authored by https://github.com/willdurand
https://github.com/mozilla-mobile/firefox-android/commit/04509ccf7772e6e5e9b9adc6f105a9812c372779
[main] Bug 1825126 - Implement onInstallPermissionRequest in WebExtensionSupport.

Comment 3

[Andrei Mocirean]

Hello! Is there anything the QA team could verify?
Thank you!

Comment 4

[Arturo Mejia [:amejia]]

Hi Andrei,
Hope you are doing well!

We would like to verify that installing an add-on continue working, mainly installing from the Fenix add-on manager ui and installing from the https://addons.mozilla.org/en-CA/firefox/ website, additional thing is everything that we could cancel the installation by dismissing the permissions permission dialog by taping outside of it.

Thanks in advance!

Comment 5

[Andrei Mocirean]

Hello,
Thanks for the info, Arturo. Hope you are doing well too!

Verified this issue, everything seems working well.
Both of install sources work for installing add-ons as long as the user accepts the permission dialog, and about cancelling the installation, here is the behaviour:

• When the user taps the "Cancel" button, "Failed to install {add-on name}" message is displayed.
• When the user taps outside of the permission dialog, the same behaviour is present and the failure message is displayed.

Marking this as verified fixed on the latest Nightly (116.0a1) from 14th of June 2023.
Tested on: Google Pixel 7 Pro (Android 13).

Thank you!

Comment 6

[Chris Peterson [:cpeterson]]

No need to uplift to 115.