Closed
Bug 1825129
Opened 2 years ago
Closed 2 years ago
Cookie Banner Reduction learn more link does not point to the correct URL
Categories
(Toolkit :: UI Widgets, defect, P3)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
113 Branch
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox111 | --- | unaffected |
firefox112 | --- | unaffected |
firefox113 | --- | fixed |
People
(Reporter: tgiles, Assigned: ebilitenelson, Mentored)
References
(Regression)
Details
(Keywords: good-first-bug, regression, Whiteboard: [fidefe-reusable-components] [lang=html])
Attachments
(1 file, 1 obsolete file)
The Cookie Banner Reduction link does not point to the correct support page. It is missing the support-page="cookie-banner-reduction"
attribute.
To help Mozilla out with this bug, here's the steps:
- Comment here on the bug that you want to volunteer to help.
This will tell others that you're working on the next steps. - Download and build the Firefox source code
- If you have any problems, please ask on Element/Matrix in the
#introduction
channel. They're there to help you get started.
- If you have any problems, please ask on Element/Matrix in the
- Start working on this bug.
- Add the missing
support-page="cookie-banner-reduction"
attribute to the cookieBannerHandlingLearnMore link
- If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the
#reusable-components
channel on Element/Matrix most hours of most days.
- Add the missing
- Build your change with
mach build
and verify your changes by ensuring the Learn more href is "https://support.mozilla.org/1/firefox/113.0a1/WINNT/en-US/cookie-banner-reduction". Also check your changes for adherence to our style guidelines by usingmach lint
. - Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
- How to Submit a Patch
- This is when the bug will be assigned to you.
- After a series of reviews and changes to your patch, I'll push it to autoland.
- If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
- Your code will soon be shipping to Firefox users worldwide!
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Hello tgiles
Working on this bug as a follow up to bug 1814426
Comment 2•2 years ago
|
||
Set release status flags based on info from the regressing bug 1814426
status-firefox111:
--- → unaffected
status-firefox112:
--- → unaffected
status-firefox113:
--- → affected
status-firefox-esr102:
--- → unaffected
Updated•2 years ago
|
Assignee: nobody → helloshahx95
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•2 years ago
|
||
Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8adc6addeb75
Cookie Banner Reduction learn more link does not point to the correct URL. r=tgiles
Updated•2 years ago
|
Attachment #9325577 -
Attachment is obsolete: true
Uchenna had already commented that they are working on this bug so I would like to be removed as an assignee.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Comment 7•2 years ago
|
||
bugherder |
Reporter | ||
Updated•2 years ago
|
Assignee: helloshahx95 → ebilitenelson
Resolution: INVALID → FIXED
Updated•2 years ago
|
Target Milestone: --- → 113 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•