1825142 - [wmfme] Support MediaFoundation clear key CDM

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P2)

Description

[Alastor Wu [:alwu]]

Microsoft's MediaFoundation clear key CDM https://github.com/microsoft/media-foundation/tree/master/samples/storecdm

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1825142 - part1 : use Media Foundation Clearkey CDM when the pref is on.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1825142 - part2 : allow clearkey system being used in the MFCDM process.

Depends on D174986

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1825142 - part2 : use RelaxedAtomicBool for the pref 'media.clearkey.test-key-systems.enabled'.

Depends on D174987

Comment 4

[Alastor Wu [:alwu]]

Attachment: WIP: Bug 1825142 - part4 : move ScopedHString to WMFUtils.

Depends on D174988

Comment 5

[Alastor Wu [:alwu]]

Attachment: WIP: Bug 1825142 - part5 : add a mechanism to load CDM from the external library.

Depends on D174989

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1825142 - part3 : implement Media Foundation ClearKey CDM in an external dll.

Depends on D174990

Comment 7

[Alastor Wu [:alwu]]

Attachment: WIP: Bug 1825142 - part5 : move the pref check into IsPlayReadyKeySystem().

Depends on D174989

Comment 8

[Alastor Wu [:alwu]]

Attachment: WIP: Bug 1825142 - part6 : use MFMediaEngineDecoderModule as EME PDM.

Depends on D175720

Comment 9

[Alastor Wu [:alwu]]

Attachment: Bug 1825142 - part5 : add crypt_byte_block and skip_byte_block attributes.

We need these attributes in the clearkey descryptor.

Depends on D174991

Comment 10

[Alastor Wu [:alwu]]

Attachment: Bug 1825142 - part6 : preload clear key related libs.

Our clearkey implemenation requires these libs.

Depends on D179150

Comment 11

[Alastor Wu [:alwu]]

Attachment: Bug 1825142 - part7 : init NSS lib.

Nss lib is used by descryption and it needs to be initialized
explicitly.

Depends on D179151

Comment 12

[Alastor Wu [:alwu]]

Attachment: Bug 1825142 - part4 : load clearkey dll.

Depends on D179152

Comment 13

[Alastor Wu [:alwu]]

Attachment: Bug 1825142 - part5 : add a pref to control dcomp surface rendering for the media engine playback.

When using clearkey CDM, enabling dcomp surface would cause crash inside
Windows dlls. So creating this pref in order to workaround the crash
problem which will allow us to create some basic EME test cases.

However, this pref should not be disabled in the normal situation
because we didn't implement a texture pool for the frame-server mode,
which will be used if we disable dcomp surface rendering.

Depends on D196240

Comment 14

[Alastor Wu [:alwu]]

Attachment: Bug 1825142 - part5 : use mock CDM (clearkey) to test all supported key systems.

Depends on D196508

Comment 15

[Alastor Wu [:alwu]]

Attachment: Bug 1825142 - part6 : enable the pref 'media.eme.playready.istypesupportedex'.

The reason of introducing this pref was to fix the test failure in bug
1851914 where the PlayReady CDM did not return correct type support on
CI.

In part10, we already changed our test to make it rely on our mock CDM
so that we don't need to worry about that failure. Therefore, we want to
re-enable this pref in order to get correct type support for PlayReady.

Depends on D196509

Comment 16

[Phabricator Automation]

Comment on attachment 9335995 [details]
Bug 1825142 - part5 : add crypt_byte_block and skip_byte_block attributes.

Revision D179150 was moved to bug 1870722. Setting attachment 9335995 [details] to obsolete.

Comment 17

[Phabricator Automation]

Comment on attachment 9335996 [details]
Bug 1825142 - part6 : preload clear key related libs.

Revision D179151 was moved to bug 1870722. Setting attachment 9335996 [details] to obsolete.

Comment 18

[Phabricator Automation]

Comment on attachment 9335997 [details]
Bug 1825142 - part7 : init NSS lib.

Revision D179152 was moved to bug 1870722. Setting attachment 9335997 [details] to obsolete.

Comment 19

[Phabricator Automation]

Comment on attachment 9368785 [details]
Bug 1825142 - part5 : add a pref to control dcomp surface rendering for the media engine playback.

Revision D196508 was moved to bug 1870722. Setting attachment 9368785 [details] to obsolete.

Comment 20

[Alastor Wu [:alwu]]

Attachment: Bug 1825142 - part7 : modify log messages.

Depends on D196510

Comment 21

[Alastor Wu [:alwu]]

Attachment: Bug 1825142 - part8 : print error message.

Depends on D197000

Comment 22

[Alastor Wu [:alwu]]

Attachment: Bug 1825142 - part9 : fix string leaking in testing.

Depends on D197403

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfa5c87b2785
part1 : use Media Foundation Clearkey CDM when the pref is on. r=jolin
https://hg.mozilla.org/integration/autoland/rev/f268790f444a
part2 : use RelaxedAtomicBool for the pref 'media.clearkey.test-key-systems.enabled'. r=media-playback-reviewers,aosmond
https://hg.mozilla.org/integration/autoland/rev/6ee026742799
part3 : implement Media Foundation ClearKey CDM in an external dll. r=jolin
https://hg.mozilla.org/integration/autoland/rev/9c144acd1ef1
part4 : load clearkey dll. r=jolin
https://hg.mozilla.org/integration/autoland/rev/27ce210ac31a
part5 : use mock CDM (clearkey) to test all supported key systems. r=jolin
https://hg.mozilla.org/integration/autoland/rev/1aabf8155584
part6 : enable the pref 'media.eme.playready.istypesupportedex'. r=media-playback-reviewers,jolin
https://hg.mozilla.org/integration/autoland/rev/86e7ca85cf58
part7 : modify log messages. r=media-playback-reviewers,aosmond
https://hg.mozilla.org/integration/autoland/rev/cc9226d67bda
part8 : print error message. r=media-playback-reviewers,aosmond
https://hg.mozilla.org/integration/autoland/rev/f60458822ae1
part9 : fix string leaking in testing. r=media-playback-reviewers,aosmond

Comment 24

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cfa5c87b2785
https://hg.mozilla.org/mozilla-central/rev/f268790f444a
https://hg.mozilla.org/mozilla-central/rev/6ee026742799
https://hg.mozilla.org/mozilla-central/rev/9c144acd1ef1
https://hg.mozilla.org/mozilla-central/rev/27ce210ac31a
https://hg.mozilla.org/mozilla-central/rev/1aabf8155584
https://hg.mozilla.org/mozilla-central/rev/86e7ca85cf58
https://hg.mozilla.org/mozilla-central/rev/cc9226d67bda
https://hg.mozilla.org/mozilla-central/rev/f60458822ae1