1825268 - Quadruple focus indication in Unified toolbar customization

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect, P3)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Four simultaneous focus indications in the customization dialog

When using Unified toolbar customization with keyboard, identifying focus soon becomes a guessing game, because focus indication is too sticky on various UI sections. Three different types of focus/active borders are pretty confusing, and the actual element which has focus doesn't stand out enough if it's a button.

STR

1. Right-click on Unified Toolbar > Customize…
2. Press Tab six times (sic)
3. Check the dialog UI for indication of focus

Actual result (with Dark Theme)

• Faint dotted blue border is used as focus indication on buttons (you can use cursor keys to move focus from one button to another within the active group).
• 4 different elements now have focus border decorations simultaneously, 3 dotted and 1 solid (see screenshot).
• On the way, huge section focus on Available for Mail Space only and Available for all Spaces - this doesn't help much.

Expected result

• Focused buttons should have the regular, clear focus indication (solid blue border).
• Focus indication should not stick around on elements which no longer have focus.
• No need for section focus imho. Instead, (initially) the first button of that section should have a clear, solid blue focus border (like the search field), and cursor keys should move that solid focus border to the other buttons. If active section border hint is wanted, it should be much de-emphasized so that the actual focus on the selected button stands out.

Comment 1

[[e-mail]]

Attachment: Bug 1825268 - Fix customization palette focus. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8443400e63bc
Fix customization palette focus. r=aleca