1825285 - error: cannot convert between vector type 'xsimd::types::simd_register<float, xsimd::avx>::register_type' and vector type 'xsimd::types::simd_register<float, xsimd::sse2>::register_type'

Status: RESOLVED FIXED

(Firefox :: Translations, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Seeing the below trying to build m-c tip today. Possibly relevant, I have ac_add_options --enable-optimize="-O2 -arch:AVX2" included in my mozconfig.

In file included from third_party/gemmology/kernels/GemmologyEngineSSE2.cpp:6:
third_party/gemmology\gemmology.h(971,26): error: cannot convert between vector type 'xsimd::types::simd_register<float, xsimd::avx>::register_type' (aka '__m256') and vector type 'xsimd::types::simd_register<float, xsimd::sse2>::register_type' (aka '__m128') as implicit conversion would cause truncation
      std::get<0>(total) + xsimd::load_aligned(bias_addr + col_idx + 0),
                         ^
third_party/gemmology\gemmology.h(1022,21): note: in instantiation of function template specialization 'gemmology::callbacks::AddBias::operator()<xsimd::sse2>' requested here
  auto bias_added = add_bias(unquantized, row_idx, col_idx, col_size);
                    ^
third_party/gemmology\gemmology.h(1261,7): note: in instantiation of function template specialization 'gemmology::callbacks::UnquantizeAndAddBiasAndWrite::operator()<std::tuple<xsimd::batch<int, xsimd::sse2>, xsimd::batch<int, xsimd::sse2>>>' requested here
      callback(total, A_rowidx, B0_colidx, B_cols);
      ^
third_party/gemmology/kernels/GemmologyEngineSSE2.cpp(13,43): note: in instantiation of function template specialization 'gemmology::Engine<xsimd::sse2>::Shift::Multiply<gemmology::callbacks::UnquantizeAndAddBiasAndWrite>' requested here
template void Engine<xsimd::sse2>::Shift::Multiply(
                                          ^
1 error generated.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1815790

:sergesanspaille, since you are the author of the regressor, bug 1815790, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[[:sergesanspaille]]

Attachment: Bug 1825285 - Do not use implicit arch parameter when loading r=ryanvm

Otherwise we end up with potentially invalid configuration when
generating code for specific architectures.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0208131327c
Do not use implicit arch parameter when loading r=RyanVM

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d0208131327c