Closed Bug 1825358 Opened 2 years ago Closed 14 days ago

[CA][inkbox.com] The preview is applied only for the selected field and the wrong dropdown/no dropdown is triggered for the already autofilled fields

Categories

(Toolkit :: Form Autofill, defect, P3)

Desktop
All
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: ailea, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug, )

Details

Attachments

(3 files)

Attached video inkbox.com_autofill.mp4

Found in

  • 113.0a1 (2023-03-29)

Affected versions

  • 113.0a1, 112.0b5, 111.0.1

Tested platforms

  • Affected platforms: Windows 10, macOS 12

Preconditions

  • browser.search.region CA
  • have an already CC saved in about:preferences

Steps to reproduce

  1. Reach the payment form on www.inkbox.com
  2. Click on the expiry date field and hover the mouse over any entry from the CC dropdown.
  3. Select an entry from the dropdown.
  4. Click on the Name on Card field in order to trigger the clear form dropdown.
  5. Click on the Card Number field.

Expected result

  1. Preview should be applied on eligible fields.
  2. Clear form dropdown should be displayed for the already autofilled fields and should clear all the CC eligible fields.

Actual result

  1. The preview is applied only for the selected field.
  2. Clear form dropdown is displayed and clears only the selected field.
  3. The CC autofill dropdown or no dropdown is displayed for the already autofilled fields instead of the clear form dropdown.

Regression range

  • Not a recent regression.

Additional notes

:ailea, if you think that's a regression, could you try to find a regression range using for example mozregression?

Priority: -- → P3
Attached video inkbox.mp4

Verified this on the latest Nightly 132.0a1, using Windows 11 and macOS 14.6, and it seems that the issue is fixed only partially, as the following are still reproducible:

  • the preview is not applied for the Card name field when triggered from the Card number / Expiration date field
  • the preview is not applied for the Card number / Expiration date field when triggered from the Card name field
  • Card name field is autofilled when triggered from the Card number field or from the Expiration date field but it is not cleared and the CC autofill dropdown is displayed instead of the clear dropdown
  • Card number / Expiration date fields are autofilled when triggered from the Card name field but they are not cleared and the CC autofill dropdown is displayed instead of the clear dropdown / no dropdown is displayed

Setting extensions.formautofill.heuristics.autofillSameOriginWithTop to True does not solve the issue.
I am also attaching a screen recording with the behavior.

Attached image about:autofill

Attached is the information from about:autofill.

There is a visible issue_date <input> in the markup that is classified as a cc-exp field, which causes issues for our heuristic.

Hi Emilio, after testing, i found

<iframe id="card-fields-issue_date-gpr0rcror8000000">

is considered as invisible with checkVisibility({checkOpacity: true, checkVisibilityCSS: true});
however, the field

<input id="issue_date">

in that <iframe> is considered as visible. I'm not sure whether this is expected, if yes, that is not a problem, i can solve this issue in our end. But i don't know how to write a testcase for this case - visible <input> in an invisible <iframe>.
Could you help provide some insights? thank you!

BTW, if you need to test, you can try this link. Note that there are multiple <input id="issue_date"> in the checkout page. The problem occurs for the one in <iframe id="card-fields-issue_date-gpr0rcror8000000">.

Flags: needinfo?(emilio)

Yes, that's expected. FWIW you can query whether you're in a hidden page by using something like this.

Flags: needinfo?(emilio)
Depends on: 1923615

Fixed by 1923615. The preview/autofill/clear are working as expected for all the CC fields, in Nightly 133.0a1 (2024-10-27).

Status: NEW → RESOLVED
Closed: 14 days ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: