1923615 - Ignroe invisible <input> while running formautofill heuristics

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P2)

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1923615 - Ignore invisible <input> while running formautofill heuristics r=#credential-management-reviewers

When identifying autofillable fields, ignore invisible <input>. However, invisible
<select> elements might still be identified as autofillable fields because some websites
implement their custom dropdown and use invisible <select> to store the value.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49ee27efd1ab
Ignore invisible <input> while running formautofill heuristics r=credential-management-reviewers,NeilDeakin

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/49ee27efd1ab

Comment 4

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49ee27efd1ab
Ignore invisible <input> while running formautofill heuristics
r=credential-management-reviewers,NeilDeakin

Perfherder has detected a browsertime performance change from push 49ee27efd1ab7cd7fff69dbb8d1b1068820d0966.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
19%	speedometer3 TodoMVC-JavaScript-ES6-Webpack-Complex-DOM/Adding100Items/Async	windows11-64-shippable-qr	fission webrender	4.79 -> 3.90	Before/After
18%	speedometer3 TodoMVC-JavaScript-ES6-Webpack-Complex-DOM/Adding100Items/Async	windows11-64-shippable-qr	fission webrender	4.73 -> 3.90	Before/After
9%	speedometer3 TodoMVC-Svelte-Complex-DOM/Adding100Items/Async	windows11-64-shippable-qr	fission webrender	6.58 -> 6.00	Before/After
7%	speedometer3 TodoMVC-Svelte-Complex-DOM/Adding100Items/total	windows11-64-shippable-qr	fission webrender	8.64 -> 8.06	Before/After
5%	speedometer3 TodoMVC-Preact-Complex-DOM/Adding100Items/Sync	windows11-64-shippable-qr	fission webrender	1.25 -> 1.18	Before/After
...	...	...	...	...	...
2%	speedometer3 Charts-observable-plot/total	windows11-64-shippable-qr	fission webrender	56.09 -> 54.96	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 2688

For more information on performance sheriffing please see our FAQ.