1825430 - Renaming or moving a folder makes its subfolders disappear

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[[e-mail]]

Steps to reproduce problem:

• Create a profile with a local folders account
• Create folder Local Folders/Folder1
• Create folder Local Folders/Folder1/Folder2
• Create folder Local Folders/Folder1/Folder2/Folder3
• Rename Folder2 to Folder4
• Note that Folder3 disappears
• Move Folder1 to Trash
• Note that Folder4 disappears

Comment 1

[Magnus Melin [:mkmelin]]

Confirmed on daily.

Comment 2

[[e-mail]]

Attachment: My local workaround

This is what I'm using to work around the bug. I've only tested on the "all" view; I don't use the other views so I don't know what the expected behaviour there is.

There is still an issue in that renaming or moving a folder always expands it. This appears to be because of the way the new code handles expansion persistence; the old code used the folder flag nsMsgFolderFlags.Elided which is set when the folder is collapsed; the various rename and move functions copy the flags to the new folder so that the collapsed state was persisted through a move or rename. (This applies to any collapsed subfolders as well of course.)

Comment 3

[Geoff Lankow (:darktrojan)]

Yeah, that's the same way I'm going to fix it. I'm dealing with the other modes and having a fight with a test at the moment.

We've handled the expansion differently for a while now, it's not new or I wouldn't have done it this way. I don't know when or why it changed, I just copied what was there. Although I will admit it's not perfect and I'll have a look into using the flag as well/instead of it. But probably not in this bug.

Comment 4

[[e-mail]]

Sorry, I wasn't meaning to suggest that you had to use the flag, I was just comparing it with when I last tried it; I hadn't realised you'd previously introduced the opposite bug whereby all the folders collapse when you move rename or move then.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1825430 - Minor improvement browser_folderTreeQuirks.js. r=#thunderbird-reviewers

This just makes checkModeListItems async and adds a timeout so that the call to expand all rows actually works. Done as a separate patch for readability.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1825430 - Fix what the folder tree does if a folder is renamed or moved. r=elizabeth

We have a problem here because the back end doesn't tell us about subfolders of folders that were moved or renamed.
At the moment I'm most concerned about getting the behaviour right and tested, so that future changes to fix and clean up this code don't break things.

Depends on D175204

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c87643e05eda
Minor improvement browser_folderTreeQuirks.js. r=leftmostcat
https://hg.mozilla.org/comm-central/rev/83359128f302
Fix what the folder tree does if a folder is renamed or moved. r=elizabeth

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9328072 [details]
Bug 1825430 - Minor improvement browser_folderTreeQuirks.js. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9328073 [details]
Bug 1825430 - Fix what the folder tree does if a folder is renamed or moved. r=elizabeth

[Triage Comment]
Approved for beta

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 113.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/56ccd9782a22
https://hg.mozilla.org/releases/comm-beta/rev/6db89da81174